Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] matchMedia memory leak #868

Merged
merged 6 commits into from
Jan 6, 2024
Merged

[fix] matchMedia memory leak #868

merged 6 commits into from
Jan 6, 2024

Commits on Sep 26, 2023

  1. [fix] matchMedia memory leak

    @kyle-go
    kyle-go committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    5c8e4c2 View commit details
    Browse the repository at this point in the history

  2. [fix] matchMedia memory leak

    @kyle-go
    kyle-go committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    8fd3b33 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. prettier:fix

    @kyle-go
    kyle-go committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    cda05ca View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. Move removeListener to unregister 

    So that it’s properly called when the DOMNode is removed from the DOM
    @EtienneLem
    EtienneLem committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    96eb041 View commit details
    Browse the repository at this point in the history

  2. Use addEventListener instead of addListener 

    See https://developer.mozilla.org/en-US/docs/Web/API/MediaQueryList#instance_methods
    @EtienneLem
    EtienneLem committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    17553dc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into main

    @EtienneLem
    EtienneLem authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    43abe6b View commit details
    Browse the repository at this point in the history