Text representation of emoji is different from emoticon #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @EtienneLem, do you see any issues with merging this? I understand if you're busy, I just want to make sure I didn't miss anything |
|
Makes sense, thanks! 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emoji-data provides the ascii representation of the emoji, available under
text. The emoticons are in thetextsfield.From the README for the
textsfield: Each ASCII emoji will only appear against a single emoji entry. This guarantees that an emoticon will map to a single emoji.The current version uses the ascii representation when no emoticon is available for an emoji, which leads to invalid results when looking up an emoticon. For example,
:)returns:blush:and:slightly_smiling_face:where there should only be a single match:slightly_smiling_face:I kept the ascii representation in the data since it might be useful to render a text-only version of the emoji.