Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIでGETリクエストを受け付ける #8263

Closed
syuilo opened this issue Feb 7, 2022 · 6 comments
Closed

APIでGETリクエストを受け付ける #8263

syuilo opened this issue Feb 7, 2022 · 6 comments
Assignees
Labels
✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR

Comments

@syuilo
Copy link
Member

syuilo commented Feb 7, 2022

Summary

  • 要望が多い
  • 情報が古くても良いユースケースでキャッシュ可能になる
@syuilo syuilo added ✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR labels Feb 7, 2022
@mei23
Copy link
Contributor

mei23 commented Feb 7, 2022

  • 意外と実装は簡単
    mei23@50239a9
  • 意外と使い道がない
    • ユーザーやノートを参照しているものはミューブロ反映する必要があるのであまり使えない
    • metaが一番効果あるけど meta, admin/meta みたいにendpointを分ける必要がある
    • stats, chartは効果ありそうだけどあまり参照されない

な感じだったわ

@tamaina
Copy link
Contributor

tamaina commented Feb 7, 2022

(metaとadmin/metaは分けていいのではと思うんだけど)

@Johann150
Copy link
Contributor

meta and admin/meta have separate URLs so they are already separately cached?

@syuilo
Copy link
Member Author

syuilo commented Jun 25, 2022

やるか(UIの改修でchartを大量に参照するようになったためキャッシュが効いてきそう)

@syuilo syuilo self-assigned this Jun 25, 2022
@syuilo
Copy link
Member Author

syuilo commented Jun 25, 2022

クエリだと全部文字列になるから数値パラメータを変換しないといけないわね

@mei23
Copy link
Contributor

mei23 commented Jun 25, 2022

クエリだと全部文字列になるから数値パラメータを変換しないといけないわね

ここを

// Cast non JSON input
if (ep.meta.requireFile && ep.params.properties) {

(ep.meta.requireFile || ctx?.method === 'GET')

にするだけで動くようしといたはずだわ

@syuilo syuilo closed this as completed in 58e83f8 Jun 25, 2022
Jeder321 pushed a commit to Jeder321/misskey that referenced this issue Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR
Projects
None yet
Development

No branches or pull requests

4 participants