Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make instances block more lenient #9258

Closed
tamaina opened this issue Dec 3, 2022 · 4 comments · Fixed by #9263
Closed

Make instances block more lenient #9258

tamaina opened this issue Dec 3, 2022 · 4 comments · Fixed by #9263
Labels
✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR

Comments

@tamaina
Copy link
Contributor

tamaina commented Dec 3, 2022

Summary

インスタンスブロック（blockedHosts）の検査をもう少し広範にする
現状、インスタンスブロック設定はblockedHosts.includes(targetHost)のように検査されており、ワイルドカード等には非対応で等しいものしかブロックできない。

blockedHosts.someでendsWithとかincludesなどで検査するようにしたい。
@tamaina tamaina added ✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR labels Dec 3, 2022
@tamaina
Copy link
Contributor Author

tamaina commented Dec 3, 2022

mastodon/mastodon#11558

MastodonはendsWithっぽい

@tamaina
Copy link
Contributor Author

tamaina commented Dec 3, 2022

SQLのWhereでNOT blockedHosts.some(x => x.endsWith(targetHost))ってどうやって表現するんだろう

@tamaina
Copy link
Contributor Author

tamaina commented Dec 3, 2022

FoundKeyだとRegExpでゴニョゴニョやってるわね

https://akkoma.dev/FoundKeyGang/FoundKey/src/commit/18cf228f893806e690be37729c75d66b32080784/packages/backend/src/misc/skipped-instances.ts

@tamaina tamaina mentioned this issue Dec 3, 2022
Merged
@tamaina
Copy link
Contributor Author

tamaina commented Dec 3, 2022

https://akkoma.dev/FoundKeyGang/FoundKey/pulls/269/files

FoundKey、RegExp(ワイルドカード)やめるらしいぜ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨Feature This adds/improves/enhances a feature packages/backend Server side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhance: Judge instance block by endsWith tamaina/misskey
1 participant
@tamaina