enhance: Judge instance block by endsWith

[tamaina]

Fix #9258

What

インスタンスブロックはendsWithで評価する

Why

嫌がらせなどのためにサブドメインをいくつも作られるのは困る

Additional info (optional)

https://github.com/tamaina/misskey/blob/181ca6bcfcdb6ddcd02beab8c5945b9ce5c3d3ac/packages/backend/src/core/chart/charts/federation.ts#L63 などのSQLを変更する必要がある（チャートなので考えなくてもあまり酷いことにはならない）

[tamaina]

SQLどうしよう（得意な人にバシッと書いてもらいたい）

[syuilo]

LIKE使うとか？

[tamaina]

SIMILAR TOを使えばいいかも？

[tamaina]

いやNOT LIKE ANYでいいのか

[tamaina]

\deploy sha=e028466

[tamaina]

/deploy sha=e028466

[syuilo]

LIKEのパフォーマンスが気になるところではある

[github-actions]

Your preview environment pr-9263-syuilo has been deployed.

Preview environment endpoint is available here

[tamaina]

blockedHosts増えるとめちゃくちゃパフォーマンス悪そう

[syuilo]

blockedHostsの数というよりはinstanceレコードの数が多いと遅くなりそう
インデックスあるけどLIKEで使ってくれるのか不明

[tamaina]

/deploy sha=d27dc2c

[tamaina]

データベース初期化されるのか

[acid-chicken]

一応確認

[tamaina]

⬆️

[tamaina]

⬆️

[codecov]

Codecov Report

Merging #9263 (8bb8a49) into develop (3e415e7) will increase coverage by 0.00%.
The diff coverage is 26.08%.

@@           Coverage Diff            @@
##           develop    #9263   +/-   ##
========================================
  Coverage    22.57%   22.58%           
========================================
  Files          731      731           
  Lines        68099    68107    +8     
  Branches      2212     2213    +1     
========================================
+ Hits         15375    15380    +5     
- Misses       52724    52727    +3     

Impacted Files	Coverage Δ
...ges/backend/src/core/activitypub/ApInboxService.ts	18.48% <0.00%> (ø)
.../backend/src/core/activitypub/ApResolverService.ts	32.38% <0.00%> (ø)
...ckend/src/core/activitypub/models/ApNoteService.ts	24.93% <0.00%> (ø)
...ckages/backend/src/core/chart/charts/federation.ts	34.12% <0.00%> (ø)
...nd/src/queue/processors/DeliverProcessorService.ts	0.00% <0.00%> (ø)
...kend/src/queue/processors/InboxProcessorService.ts	0.00% <0.00%> (ø)
...kend/src/server/api/endpoints/admin/update-meta.ts	0.00% <0.00%> (ø)
...ckages/backend/src/server/api/endpoints/ap/show.ts	0.00% <0.00%> (ø)
packages/backend/src/core/UtilityService.ts	67.34% <50.00%> (-2.43%)	⬇️
...backend/src/core/entities/InstanceEntityService.ts	47.54% <75.00%> (+1.77%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[tamaina]

QueryFailedError: syntax error at or near "{"
(略)
query: 'SELECT COUNT(DISTINCT "following"."followeeHost") FROM "following" "following" WHERE "following"."followeeHost" IS NOT NULL AND "following"."followeeHost" NOT LIKE ANY({$1, $2, $3, $4, $5, $6, $7, $8, $9, $10}) AND "following"."followeeHost" NOT IN (SELECT "instance"."host" AS "instance_host" FROM "instance" "instance" WHERE "instance"."isSuspended" = true)',
parameters: [
'activitypub-troll.cf',
'%.activitypub-troll.cf',
...
],

みたいに言われる

[tamaina]

Jan 12 06:57:51 instance-20211023-1036 p1.a9z.dev[771719]: query: 'SELECT COUNT(DISTINCT "following"."followeeHost") FROM "following" "following" WHERE "following"."followeeHost" IS NOT NULL AND "following"."followeeHost" NOT LIKE ANY($1, $2, $3, $4, $5, $6, $7, $8, $9, $10) AND "following"."followeeHost" NOT IN (SELECT "instance"."host" AS "instance_host" FROM "instance" "instance" WHERE "instance"."isSuspended" = true) AND "following"."followeeHost" IN (SELECT "f"."followerHost" AS "f_followerHost" FROM "following" "f" WHERE "f"."followerHost" IS NOT NULL)',

ですよね

[tamaina]

• 使い方合ってるかわからないけどARRAY[:...blocked]と書くようにした
• 大文字小文字を区別しないのを徹底するようにした

[syuilo]

🙏🏻