Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(server): add validation test of api:notes/create #10090

Merged
merged 13 commits into from
Feb 26, 2023
Merged

test(server): add validation test of api:notes/create #10090

merged 13 commits into from
Feb 26, 2023

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Feb 25, 2023

#10082 のバリデーションのテストを書いてみた
（サービスのテストの書き方がわからないので書かないことに決めた）

apiエンドポイントのテストファイルは.test.tsに書きたかった（ダメなら他の場所にする）

@github-actions github-actions bot added packages/backend Server side specific issue/PR 🧪Test labels Feb 25, 2023
@tamaina tamaina changed the title test(server): add validation test(server): add validation test of api:notes/create Feb 25, 2023
@codecov
Copy link

codecov bot commented Feb 25, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@0691901). Click here to learn what that means.
The diff coverage is 32.25%.

❗ Current head b720ac6 differs from pull request most recent head 4aececf. Consider uploading reports for the commit 4aececf to get more accurate results

@@            Coverage Diff             @@
##             develop   #10090   +/-   ##
==========================================
  Coverage           ?   25.06%           
==========================================
  Files              ?      705           
  Lines              ?    65150           
  Branches           ?     2307           
==========================================
  Hits               ?    16328           
  Misses             ?    48822           
  Partials           ?        0
Impacted Files Coverage Δ
packages/backend/src/misc/schema.ts 0.00% <0.00%> (ø)
.../src/server/api/endpoints/admin/drive/show-file.ts 0.00% <0.00%> (ø)
...ckend/src/server/api/endpoints/drive/files/show.ts 0.00% <0.00%> (ø)
...nd/src/server/api/endpoints/notes/search-by-tag.ts 0.00% <0.00%> (ø)
...ges/backend/src/server/api/endpoints/pages/show.ts 0.00% <0.00%> (ø)
...ackend/src/server/api/endpoints/users/followers.ts 0.00% <0.00%> (ø)
...ackend/src/server/api/endpoints/users/following.ts 0.00% <0.00%> (ø)
...api/endpoints/users/search-by-username-and-host.ts 0.00% <0.00%> (ø)
...ges/backend/src/server/api/endpoints/users/show.ts 0.00% <0.00%> (ø)
...s/backend/src/server/api/endpoints/notes/create.ts 54.23% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamaina
Copy link
Contributor Author

tamaina commented Feb 25, 2023

（apiのバリデーションのテストを書くとカバレッジ荒稼ぎできるっぽい！？）

@tamaina
Copy link
Contributor Author

tamaina commented Feb 25, 2023

image

これのいい解決策募集中

@tamaina tamaina requested review from syuilo and rinsuki February 25, 2023 15:00
@tamaina
Copy link
Contributor Author

tamaina commented Feb 25, 2023

image

これでいいか

@syuilo
Copy link
Member

syuilo commented Feb 26, 2023

apiエンドポイントのテストファイルは.test.tsに書きたかった（ダメなら他の場所にする）

👍

@syuilo syuilo merged commit 18dbcfa into misskey-dev:develop Feb 26, 2023
@syuilo
Copy link
Member

syuilo commented Feb 26, 2023

👍🏻👍🏻

@syuilo syuilo mentioned this pull request Feb 26, 2023
Closed
syuilo added a commit that referenced this pull request Feb 26, 2023
@syuilo @atsu1125
@massongit @tamaina @saschanaz @taiyme @xianonn @kabo2468 @yszkst @Khsmty @SoniEx2 @mei23 @daima3629 @windymelt
Merge pull request #10108 from misskey-dev/develop
02c8fd9 
* Add dialog to remove follower (#9718)

* update PULL_REQUEST_TEMPLATE

* 起動時にRedisの疎通確認を行う (#9832)

* 起動時にRedisの疎通確認を行う

* check:connectをstart内に移動

---------

Co-authored-by: tamaina <tamaina@hotmail.co.jp>

* Pass `--detectOpenHandles` to Jest (#9895)

Co-authored-by: tamaina <tamaina@hotmail.co.jp>

* enhance(client): MkUrlPreviewの閉じるボタンを見やすく (#9913)

Co-authored-by: tamaina <tamaina@hotmail.co.jp>

* test(backend): restore ap-request tests (#9997)

Co-authored-by: tamaina <tamaina@hotmail.co.jp>

* fix/refaftor(client): MkTime.vueの変更 (#10061)

* fix(client): MkTime.timeにstringでもDateでない値が入った場合、？を表示

* fix(client): MkTimeを改良

* numberを許容

* falsyな値もとる

* 不明

* ありません

* fix

* fix(server): notes/createで、fileIdsと見つかったファイルの数が異なる場合はエラーにする (#9911)

* fix(server): notes/createで、fileIdsと見つかったファイルの数が異なる場合はエラーにする

* NO_SUCH_FILE

* Update codecov.yml

* Update apple-touch-icon.png

* デプロイされているプレビュー環境がない場合はプレビュー環境を削除しないようにする (#10062)

* デプロイされているプレビュー環境がない場合はDestroy preview environmentを実行しないようにする

* CIがない場合の処理追加

* enhance(client): improve clip menu ux

* 未知のユーザーが deleteActor されたら処理をスキップする (#10067)

* fix(client): Android ChromeでPWAとしてインストールできない問題を修正 (#10069)

* fix(client): Android ChromeでPWAとしてインストールできない問題を修正

* 順番関係ある？

* Windows環境でswcを使うと正常にビルドができない問題の修正 (#10074)

* Update @swc/core to v1.3.36

* Update CHANGELOG.md

* Update CHANGELOG.md

* バックグラウンドで一定時間経過したらページネーションのアイテム更新をしない (#10053)

* 🎨

* feat: 2つの検索画面の統合 (#9949) (#10038)

* feat: 検索画面の UI を統一

* fix: エラーの修正

* add: changelog

---------

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>

* enhance(client): ノートメニューからユーザーメニューを開けるように

Resolve #10019

* enhance(client): renoteした際の表示を改善

Resolve #10078

* Update CHANGELOG.md

* enhance(client): tweak contextmenu position calculation

* 🎨

* 🎨

* feat: in-channel featured note

Resolve #9938

* refactor(frontend): fix eslint error (#10084)

* Simplify search.vue (remove dead code) (#10088)

* Simplify search.vue

This is already handled by the code above it, no need to handle it twice

* Remove unused imports

* Update about-misskey.vue

* test(server): add validation test of api:notes/create (#10090)

* fix(server): notes/createのバリデーションが効いていない
Fix #10079

Co-Authored-By: mei23 <m@m544.net>

* anyOf内にバリデーションを書いても最初の一つしかチェックされない

* ✌️

* wip

* wip

* ✌️

* RequiredProp

* Revert "RequiredProp"

This reverts commit 7469390.

* add api:notes/create

* fix lint

* text

* ✌️

* improve readability

---------

Co-authored-by: mei23 <m@m544.net>
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>

* New Crowdin updates (#10059)

* New translations ja-JP.yml (Japanese, Kansai)

* New translations ja-JP.yml (Romanian)

* New translations ja-JP.yml (French)

* New translations ja-JP.yml (Spanish)

* New translations ja-JP.yml (Arabic)

* New translations ja-JP.yml (Czech)

* New translations ja-JP.yml (German)

* New translations ja-JP.yml (Italian)

* New translations ja-JP.yml (Korean)

* New translations ja-JP.yml (Polish)

* New translations ja-JP.yml (Russian)

* New translations ja-JP.yml (Slovak)

* New translations ja-JP.yml (Ukrainian)

* New translations ja-JP.yml (Chinese Simplified)

* New translations ja-JP.yml (Chinese Traditional)

* New translations ja-JP.yml (English)

* New translations ja-JP.yml (Vietnamese)

* New translations ja-JP.yml (Indonesian)

* New translations ja-JP.yml (Bengali)

* New translations ja-JP.yml (Thai)

* New translations ja-JP.yml (Japanese, Kansai)

* New translations ja-JP.yml (Chinese Traditional)

* New translations ja-JP.yml (Chinese Traditional)

* New translations ja-JP.yml (German)

* New translations ja-JP.yml (English)

* New translations ja-JP.yml (German)

* New translations ja-JP.yml (Ukrainian)

* New translations ja-JP.yml (Chinese Simplified)

* New translations ja-JP.yml (English)

* New translations ja-JP.yml (Ukrainian)

* New translations ja-JP.yml (Ukrainian)

* New translations ja-JP.yml (Ukrainian)

* New translations ja-JP.yml (Chinese Simplified)

* New translations ja-JP.yml (Japanese, Kansai)

* New translations ja-JP.yml (Thai)

* New translations ja-JP.yml (Thai)

* New translations ja-JP.yml (Thai)

* New translations ja-JP.yml (Spanish)

* New translations ja-JP.yml (Spanish)

* enhance(client): improve user menu ux

* enhance(client): photoswipe 表示時に戻る操作をしても前の画面に戻らないように (#10098)

* enhance(client): photoswipe 表示時に戻る操作をしても前の画面に戻らないように

* add: changelog

---------

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>

* enhance(client): メニューの「もっと」からインスタンス情報を見れるように

* [Fix] fixed an typo in error message (#10102)

* Update codecov.yml

* Update CHANGELOG.md

* fix(server): エラーのスタックトレースは返さないように

Fix #10064

* [chore]Editorconfig: ymlに加えてyamlファイルに対しても同じ規約を適用する (#10081)

* Added yaml file in addition to yml file, in editorconfig

* Applied editorconfig for pnpm-workspace.yaml

---------

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>

* update deps

* ホームタイムラインの読み込みでクエリタイムアウトになるのを修正する (#10106)

* refactor

* New translations ja-JP.yml (French) (#10103)

* Update CHANGELOG.md

* 13.8.0

---------

Co-authored-by: atsuchan <83960488+atsu1125@users.noreply.github.com>
Co-authored-by: Masaya Suzuki <15100604+massongit@users.noreply.github.com>
Co-authored-by: tamaina <tamaina@hotmail.co.jp>
Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
Co-authored-by: taiy <53635909+taiyme@users.noreply.github.com>
Co-authored-by: xianon <xianon@hotmail.co.jp>
Co-authored-by: kabo2468 <28654659+kabo2468@users.noreply.github.com>
Co-authored-by: YS <47836716+yszkst@users.noreply.github.com>
Co-authored-by: Khsmty <me@khsmty.com>
Co-authored-by: Soni L <EnderMoneyMod@gmail.com>
Co-authored-by: mei23 <m@m544.net>
Co-authored-by: daima3629 <52790780+daima3629@users.noreply.github.com>
Co-authored-by: Windymelt <1113940+windymelt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syuilo syuilo Awaiting requested review from syuilo

@rinsuki rinsuki Awaiting requested review from rinsuki

Assignees
No one assigned
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamaina @syuilo