Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sw): プッシュ通知でカスタム絵文字リアクションを表示できるように #10122

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Feb 26, 2023

Fix #10117

/emoji/*.webpにbadgeモードを追加し、そこにリクエストする

p1.a9z.devで動作中

@tamaina tamaina marked this pull request as draft February 26, 2023 14:32
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Feb 26, 2023
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #10122 (6418cd1) into develop (81e6a21) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #10122      +/-   ##
===========================================
- Coverage    25.06%   25.06%   -0.01%     
===========================================
  Files          705      705              
  Lines        65151    65159       +8     
  Branches      2307     2307              
===========================================
  Hits         16329    16329              
- Misses       48822    48830       +8     
Impacted Files Coverage Δ
packages/backend/src/server/ServerService.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamaina tamaina marked this pull request as ready for review February 26, 2023 16:00
@syuilo
Copy link
Member

syuilo commented Feb 28, 2023

IMG_2987
こうなった

@tamaina
Copy link
Contributor Author

tamaina commented Feb 28, 2023

Androidでないとバッジは表示されない

@tamaina
Copy link
Contributor Author

tamaina commented Feb 28, 2023

(かと言ってアイコンが指定できるわけでもない

@tamaina
Copy link
Contributor Author

tamaina commented Feb 28, 2023

Screenshot_20230228-194507.png

Androidだとこんな感じ

@syuilo syuilo merged commit ffe3386 into misskey-dev:develop Feb 28, 2023
@syuilo
Copy link
Member

syuilo commented Feb 28, 2023

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service Workerがnotes.emojisの変更に対応できていない
2 participants