Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): photoswipe（画像の拡大表示）がなんか変 #10138

Merged
merged 3 commits into from
Feb 28, 2023
Merged

fix(client): photoswipe（画像の拡大表示）がなんか変 #10138

merged 3 commits into from
Feb 28, 2023

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Feb 27, 2023

Fix #10037

  • backdrop-filterなどが効いていない問題を修正（mainClassを$style.pswpに指定）
  • z-indexを計算して指定
  • パディングについて下部のテキストコンテナを考慮
  • 下部のテキストコンテナのbottomを10px下げる

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Feb 27, 2023
@tamaina tamaina requested a review from syuilo February 27, 2023 13:00
@syuilo
Copy link
Member

syuilo commented Feb 28, 2023

手元で動かしたところぼかしが効いてなかった

@tamaina
Copy link
Contributor Author

tamaina commented Feb 28, 2023

Firefoxでは効くけどChrome/Safariでは効かない
（そういう仕様らしい）

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #10138 (ca4b3eb) into develop (4ea9780) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #10138   +/-   ##
========================================
  Coverage    25.05%   25.05%           
========================================
  Files          705      705           
  Lines        65180    65180           
  Branches      2307     2307           
========================================
  Hits         16329    16329           
  Misses       48851    48851

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamaina
Copy link
Contributor Author

tamaina commented Feb 28, 2023

will-changeが悪いみたいなんだけど、will-changeを上書きするのは効果ない

@syuilo
Copy link
Member

syuilo commented Feb 28, 2023

じゃあしょうがないか

@syuilo syuilo merged commit 17d0bde into misskey-dev:develop Feb 28, 2023
@syuilo
Copy link
Member

syuilo commented Feb 28, 2023

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syuilo syuilo Awaiting requested review from syuilo

Assignees
No one assigned
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

photoswipe（画像の拡大表示）がなんか変
2 participants
@tamaina @syuilo