enhance(backend): 配送先が410 Goneで応答してきた場合配送停止するように #10298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #10298 +/- ##
===========================================
- Coverage 74.11% 74.10% -0.02%
===========================================
Files 809 809
Lines 77565 77577 +12
Branches 5481 5481
===========================================
Hits 57491 57491
- Misses 20074 20086 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
EbiseLutica
approved these changes
Mar 11, 2023
|
CHANGELOGあった方が良さそう |
… instance-auto-suspend
|
CHANGELOG書いた |
|
🙏🙏 |
mei23
reviewed
Mar 13, 2023
Comment on lines
+118
to
+129
| // 相手が閉鎖していることを明示しているため、配送停止する | ||
| if (res.statusCode === 410) { | ||
| this.federatedInstanceService.fetch(host).then(i => { | ||
| this.instancesRepository.update(i.id, { | ||
| isSuspended: true, | ||
| }); | ||
| this.federatedInstanceService.updateCachePartial(host, { | ||
| isSuspended: true, | ||
| }); | ||
| }); | ||
| return `${host} is gone`; | ||
| } |
There was a problem hiding this comment.
sharedInboxに配送して410を返されるパターンの他に、削除済みユーザー個人のinboxに配送して410を返されるパターンがあって、後者の場合はホスト全体を配送停止してはいけない。
なので、配送先がsharedInboxなのかinboxなのかをキューに持たせといて、sharedInboxへの配送が410だった場合のみ停止しないといけない。
There was a problem hiding this comment.
4 tasks
syuilo
pushed a commit
that referenced
this pull request
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolve #9807
Why
メンテナンスコスト削減
Checklist