refactor(backend): validateNoteの引数の型を強くし、anyを除去 #10325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KisaragiEffective
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #10325 +/- ##
============================================
+ Coverage 74.41% 94.71% +20.30%
============================================
Files 872 2 -870
Lines 85156 454 -84702
Branches 5599 59 -5540
============================================
- Hits 63367 430 -62937
+ Misses 21789 24 -21765 see 874 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
テストが長い |
|
🙏 🙏🙏 |
na2na-p
pushed a commit
to na2na-p/misskey
that referenced
this pull request
May 10, 2023
* refactor(backend): validateNoteの引数の型を推論する * fix(backend): アサーションの内容から推論してエラーの内容を期待されるであろう式へと変更する * refactor Co-authored-by: Acid-Chicken <root@acid-chicken.com> --------- Co-authored-by: tamaina <tamaina@hotmail.co.jp> Co-authored-by: Acid-Chicken <root@acid-chicken.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
validateNoteメソッドからanyを取り除きました。Why
#3622
Additional info
議論の余地があると思われる変更点
Checklist