Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: integrate misskey-js as a workspace item (git subtree) #10409

Merged
merged 3 commits into from
Mar 30, 2023
Merged

chore: integrate misskey-js as a workspace item (git subtree) #10409

merged 3 commits into from
Mar 30, 2023

Conversation

saschanaz
Copy link
Member

What

misskey-jsの統合

Why

もっと管理しやすくするために

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Closes #10322
Closes #10340

@saschanaz
Add 'packages/misskey-js/' from commit '13a2d16eab8637b6250396548619c…
20be90d 
…d2cdf80a3c3'

git-subtree-dir: packages/misskey-js
git-subtree-mainline: 772e05e
git-subtree-split: 13a2d16
@saschanaz
Additional changes for the merge
1adb846
@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR labels Mar 25, 2023
@codecov
Copy link

codecov bot commented Mar 25, 2023 •
edited
Loading

Codecov Report

Merging #10409 (dc96c53) into develop (772e05e) will increase coverage by 0.10%.
The diff coverage is 95.24%.

@@             Coverage Diff             @@
##           develop   #10409      +/-   ##
===========================================
+ Coverage    75.07%   75.17%   +0.10%     
===========================================
  Files          879      881       +2     
  Lines        86017    86459     +442     
  Branches      5837     5890      +53     
===========================================
+ Hits         64576    64997     +421     
- Misses       21441    21462      +21
Impacted Files Coverage Δ
packages/misskey-js/src/streaming.ts 93.82% <93.82%> (ø)
packages/misskey-js/src/api.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@saschanaz
Copy link
Member Author

saschanaz commented Mar 25, 2023 •
edited
Loading

https://github.com/misskey-dev/misskey/blame/misskey-js-subtree/packages/misskey-js/src/acct.ts

image

何とか出来ました

syuilo
syuilo reviewed Mar 28, 2023
View reviewed changes
.github/workflows/api.yml Outdated Show resolved Hide resolved
@saschanaz saschanaz mentioned this pull request Mar 29, 2023
Open
@syuilo syuilo merged commit cee1d5e into develop Mar 30, 2023
@syuilo syuilo deleted the misskey-js-subtree branch March 30, 2023 00:33
@syuilo
Copy link
Member

syuilo commented Mar 30, 2023

🙏🙏🙏

@syuilo
Copy link
Member

syuilo commented Mar 30, 2023

なんか出た
image

@syuilo
Copy link
Member

syuilo commented Mar 30, 2023

直った
e9769c9

@saschanaz
Copy link
Member Author

Squashマージでblame history消えてしまったです👀

@saschanaz
Copy link
Member Author

(git subtreeではなくなりました)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syuilo syuilo syuilo left review comments

@acid-chicken acid-chicken Awaiting requested review from acid-chicken

@rinsuki rinsuki Awaiting requested review from rinsuki

Assignees
No one assigned
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

misskey.jsをこのレポに統合
2 participants
@saschanaz @syuilo