Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(#10336): use TurboSnap #10494

Merged
merged 40 commits into from
Apr 7, 2023
Merged

ci(#10336): use TurboSnap #10494

merged 40 commits into from
Apr 7, 2023

Conversation

acid-chicken
Copy link
Member

@acid-chicken acid-chicken commented Apr 6, 2023

What

https://www.chromatic.com/docs/turbosnap

Why

Chromatic クレジットの節約

Additional info (optional)

35,000/mo のスナップショットが提供されているが今月すでに 5,000 近くを使用しておりこのまま行くと明らかに使い切る

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #10494 (cce50dd) into develop (191ed3c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #10494   +/-   ##
========================================
  Coverage    75.27%   75.27%           
========================================
  Files          881      881           
  Lines        86409    86409           
  Branches      5886     5882    -4     
========================================
  Hits         65043    65043           
  Misses       21366    21366           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@acid-chicken acid-chicken marked this pull request as draft April 6, 2023 05:27
@acid-chicken
Copy link
Member Author

なんもわからん

@acid-chicken
Copy link
Member Author

Retrieving story files affected by recent changes
→ Traversing dependencies for 1 file that changed since the last build
{"baselineCommits":["cb0e7e3f45e7369fc0c0c3b02c94c96f819a051e"]} Finding changed dependencies for 1 baselines
{"rootPath":"/home/runner/work/misskey/misskey","rootManifestPath":"package.json"} No manifest or lockfile found at the root of the repository
{"name":"Error","message":"Could not find package.json, package-lock.json or yarn.lock at the root of the repository","stack":"Error: Could not find package.json, package-lock.json or yarn.lock at the root of the repository\n at /home/runner/work/_actions/chromaui/action/v1/action/main.js:677:18839\n at Generator.next ()\n at a (/home/runner/work/_actions/chromaui/action/v1/action/main.js:677:17836)\n at processTicksAndRejections (node:internal/process/task_queues:96:5)"}
Could not retrieve dependency changes from lockfiles; checking package.json
ℹ Traced 1 changed file to 0 affected story files:

あー……

@acid-chicken
Copy link
Member Author

@acid-chicken acid-chicken reopened this Apr 6, 2023
@acid-chicken acid-chicken marked this pull request as ready for review April 6, 2023 15:45
@github-actions github-actions bot requested a review from tamaina April 6, 2023 15:46
Comment on lines 223 to 225
.tabIcon {
width: 1.28em;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamaina 当該箇所は MkPageHeader タブアイコン部のサイズが Tabler Icons のフォント読み込みでレイアウトシフトするのを防いでるつもりなんだけど固定して問題なさそう?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そこに限らずTabkerIcons使ってる箇所は全てレイアウトシフト発生する可能性ない?
とするともう

とかで幅固定させて良い気もする

@acid-chicken
Copy link
Member Author

TurboSnap でなんか動かない部分を補った

@acid-chicken
Copy link
Member Author

acid-chicken commented Apr 7, 2023

対象となる stories がないときに UI Review の checks が見かけ上 ✅ になる(Chromatic 上では 🟡 になる)問題があるけど、これはどうしようもなさそう

@acid-chicken
Copy link
Member Author

コメントするようにした

5c45ab2#commitcomment-107945982

けどいつの間にかコミットコメントが PR に入らなくなったっぽい?

@syuilo syuilo merged commit abda3b6 into develop Apr 7, 2023
@syuilo syuilo deleted the chromatic-turbosnap branch April 7, 2023 11:34
@syuilo
Copy link
Member

syuilo commented Apr 7, 2023

🙏🏻🙏🏻🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants