Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): リスト、クリップが無限ロードされる現象の解決 #10538

Merged
merged 3 commits into from
Apr 8, 2023

Conversation

tai-cha
Copy link
Contributor

@tai-cha tai-cha commented Apr 8, 2023

What

fix: #10536

  • リスト管理(my-list/index)でリストが無限に読み込まれ増殖していたものを修正
before after
infinite list fixed
  • 自分のクリップ(my-clip/index)でクリップが無限に読み込まれ増殖していたものを修正
before after
infinite fixed

Why

リストが重複して表示されないようにしたい
リストは全件取得であるのにPagingが働き無限ロードされる挙動になっているため抑制した

クリップにも同様のバグが存在した

Additional info (optional)

アンテナの同様のバグの修正commit: 1c158dc#diff-21d49bc99055cbf7412c3a4019e79c6e6f565d064397fb829e8e0d9cbfcb5ce3R30

アンテナのバグに関して(13.11.0 PR内): #10506 (comment)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Apr 8, 2023
@tai-cha tai-cha marked this pull request as ready for review April 8, 2023 21:11
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #10538 (7016410) into develop (64597a2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #10538   +/-   ##
========================================
  Coverage    75.12%   75.12%           
========================================
  Files          886      886           
  Lines        87086    87086           
  Branches      5905     5907    +2     
========================================
  Hits         65420    65420           
  Misses       21666    21666           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tai-cha tai-cha changed the title fix(client): my-list/indexでリストが無限ロードされる現象の解決 fix(client): my-list/index, my-clips/indexでリストが無限ロードされる現象の解決 Apr 8, 2023
@tai-cha tai-cha force-pushed the fix-my-list-infinite branch from 0213e1c to 7016410 Compare April 8, 2023 21:46
@tai-cha tai-cha changed the title fix(client): my-list/index, my-clips/indexでリストが無限ロードされる現象の解決 fix(client): my-list/index, my-clips/indexでリスト、クリップが無限ロードされる現象の解決 Apr 8, 2023
@tai-cha tai-cha changed the title fix(client): my-list/index, my-clips/indexでリスト、クリップが無限ロードされる現象の解決 fix(client): リスト、クリップが無限ロードされる現象の解決 Apr 8, 2023
@syuilo syuilo merged commit f794f3a into misskey-dev:develop Apr 8, 2023
@syuilo
Copy link
Member

syuilo commented Apr 8, 2023

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

リスト・自分のクリップが無限に重複して表示される
2 participants