perf(frontend): MkImgWithBlurhashでblurhash描画に使うcanvasは再利用するようにする #10966
+39
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamaina
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #10966 +/- ##
===========================================
Coverage 77.34% 77.35%
===========================================
Files 739 907 +168
Lines 70536 91418 +20882
Branches 7103 7539 +436
===========================================
+ Hits 54556 70716 +16160
- Misses 15980 20702 +4722
|
|
p1.a9z.dev 眺めてる限りではいい感じに動いてそう |
Comment on lines
+29
to
+30
| canvas.width = 64; | ||
| canvas.height = 64; |
There was a problem hiding this comment.
サイズが大きくても buraha の速度はほぼ変わらない
There was a problem hiding this comment.
保持しておくcanvasのサイズが大きいとメモリを食いまくるような気がする
There was a problem hiding this comment.
（表示に使うHTMLCanvasElementの話
Merged
slofp
pushed a commit
to Secineralyr/misskey.dream
that referenced
this pull request
Jul 21, 2023
…skey-dev#10966) * blurhashを描画するためのcanvasは再利用する * Revert "perf(frontend): WebGL contextの数を減らす" This reverts commit aeb8955. * MkAvatarは平均色だけにする * clean up * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10960
What
Why
Checklist