Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deck uiでuser listを見たときにリプライが表示されない #11951

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

anatawa12
Copy link
Member

@anatawa12 anatawa12 commented Oct 2, 2023

What

Fix #11948

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6840434) 79.00% compared to head (917eb6b) 78.92%.
Report is 9 commits behind head on develop.

❗ Current head 917eb6b differs from pull request most recent head 9a2c3bc. Consider uploading reports for the commit 9a2c3bc to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11951      +/-   ##
===========================================
- Coverage    79.00%   78.92%   -0.09%     
===========================================
  Files          928      928              
  Lines        99089    99089              
  Branches      7913     7882      -31     
===========================================
- Hits         78289    78205      -84     
- Misses       20800    20884      +84     

see 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anatawa12
Copy link
Member Author

anatawa12 commented Oct 2, 2023

デフォルト値は古い動作に合わせるという点においてもtrueが自然だと思います

@syuilo syuilo merged commit 5fd0cb3 into misskey-dev:develop Oct 3, 2023
8 of 9 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 3, 2023

👍🏻

@anatawa12 anatawa12 deleted the fix-user-list-colum-replies branch November 24, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Listカラムでリプライが表示されない
2 participants