Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 2023.10.1 #12011

Merged
merged 12 commits into from
Oct 12, 2023
Merged

Release: 2023.10.1 #12011

merged 12 commits into from
Oct 12, 2023

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Oct 11, 2023

General

  • Enhance: ローカルタイムライン、ソーシャルタイムラインで返信を含むかどうか設定可能に

Client

  • Fix: 絵文字ピッカーで横に長いカスタム絵文字が見切れる問題を修正

Server

  • Fix: フォローしているユーザーからの自分の投稿への返信がタイムラインに含まれない問題を修正
  • Fix: users/notesでセンシティブチャンネルの投稿が含まれる場合がある問題を修正

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/backend:test labels Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (854ac95) 79.28% compared to head (7b6b3ad) 79.27%.
Report is 32 commits behind head on master.

❗ Current head 7b6b3ad differs from pull request most recent head 87c9870. Consider uploading reports for the commit 87c9870 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12011      +/-   ##
==========================================
- Coverage   79.28%   79.27%   -0.02%     
==========================================
  Files         930      930              
  Lines       99366    99410      +44     
  Branches     8076     8078       +2     
==========================================
+ Hits        78787    78810      +23     
- Misses      20579    20600      +21     
Files Coverage Δ
packages/backend/src/core/NoteCreateService.ts 90.65% <100.00%> (+0.03%) ⬆️
.../src/server/api/endpoints/notes/hybrid-timeline.ts 97.59% <100.00%> (+1.64%) ⬆️
...d/src/server/api/endpoints/notes/local-timeline.ts 97.40% <100.00%> (+0.25%) ⬆️
...es/backend/src/server/api/endpoints/users/notes.ts 94.59% <100.00%> (+0.05%) ⬆️
.../src/server/api/stream/channels/hybrid-timeline.ts 90.78% <100.00%> (+0.13%) ⬆️
...d/src/server/api/stream/channels/local-timeline.ts 95.00% <100.00%> (+0.08%) ⬆️
packages/frontend/src/components/MkEmojiPicker.vue 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member Author

syuilo commented Oct 11, 2023

  • Timelines › Local TL › [withReplies: true] 他人の他人への返信が含まれる

のテストが失敗する理由が謎(手動での確認では正しい動作をしている)

@syuilo
Copy link
Member Author

syuilo commented Oct 11, 2023

tasukete

@syuilo
Copy link
Member Author

syuilo commented Oct 11, 2023

  • Timelines › Local TL › [withReplies: true] 他人の他人への返信が含まれる

のテストが失敗する理由が謎(手動での確認では正しい動作をしている)

原因としてはおそらく、100近いテストが並列で動いてるから他のテストで追加されたノートでLTLが押し流されてデフォルトの取得limitの範囲からは対象のノートがいなくなることだと思われる

@syuilo syuilo marked this pull request as ready for review October 11, 2023 05:32
@Nanashia
Copy link
Contributor

Nanashia commented Oct 11, 2023

NoteCreateService.pushToTl()がテストのwaitForPushToTl()の300msの待ちを超えてしまってTL取得に負けるケースがあるかも?

@syuilo
Copy link
Member Author

syuilo commented Oct 11, 2023

NoteCreateService.pushToTl()がテストのwaitForPushToTl()の300msの待ちを超えてしまってTL取得に負けるケースがあるかも?

それも疑ったけど、増やしても変わらないから関係なさそう

@syuilo
Copy link
Member Author

syuilo commented Oct 11, 2023

あ、 #12011 (comment) 以外の失敗についてはその可能性はありそう

@syuilo
Copy link
Member Author

syuilo commented Oct 11, 2023

ご確認お願いします @misskey-dev/dev
テストはローカルでは通っているのを確認済み

* New translations ja-jp.yml (Chinese Traditional)

* New translations ja-jp.yml (Chinese Traditional)
@syuilo syuilo merged commit 7e7138c into master Oct 12, 2023
17 of 18 checks passed
@syuilo
Copy link
Member Author

syuilo commented Oct 12, 2023

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants