-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: 2023.10.1 #12011
Release: 2023.10.1 #12011
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12011 +/- ##
==========================================
- Coverage 79.28% 79.27% -0.02%
==========================================
Files 930 930
Lines 99366 99410 +44
Branches 8076 8078 +2
==========================================
+ Hits 78787 78810 +23
- Misses 20579 20600 +21
☔ View full report in Codecov by Sentry. |
のテストが失敗する理由が謎(手動での確認では正しい動作をしている) |
tasukete |
原因としてはおそらく、100近いテストが並列で動いてるから他のテストで追加されたノートでLTLが押し流されてデフォルトの取得limitの範囲からは対象のノートがいなくなることだと思われる |
NoteCreateService.pushToTl()がテストのwaitForPushToTl()の300msの待ちを超えてしまってTL取得に負けるケースがあるかも? |
それも疑ったけど、増やしても変わらないから関係なさそう |
あ、 #12011 (comment) 以外の失敗についてはその可能性はありそう |
ご確認お願いします @misskey-dev/dev |
* New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (Chinese Traditional)
🙏🏻 |
General
Client
Server