Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 外部サイトからテーマ・プラグインのインストールができるように #12034

Merged
merged 30 commits into from
Oct 21, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

What

image

image

Why

Fix #11992

コピペの手間を省けるようにする

Additional info (optional)

動作確認用URL

正常動作

  • プラグイン: /install-extentions?url=https://gist.githubusercontent.com/kakkokari-gtyih/9fa43dc88cc77a6ca5e6552c4eb6b160/raw/e3d8bb24a41da5a20115a00b24040cb8c7547410/plugin-api-test.json&hash=866b55d02dc7f4d19553e6e1f86582f410ba6ade11c62ebdf66521eb24c66932dd51e48c69f4ae3c1d88b48eef54fa6c6ee3673c65f523791e527d7faf6c2a5d
  • テーマ: /install-extentions?url=https://gist.githubusercontent.com/kakkokari-gtyih/9fa43dc88cc77a6ca5e6552c4eb6b160/raw/4d4ce1c301581e52d8e024080596f99fe78022ce/theme-api-test.json&hash=c68d7a4cda9550f41065f0538b548f22d1c3dca5f0e230b4d553f24aa42d4ae647da245f8f3e7f58df97d1e008a6e63ffe405234c0e1a46db6be71861c23812d

エラー

  • プラグイン (Invalid AiScript): /install-extentions?url=https://gist.githubusercontent.com/kakkokari-gtyih/9fa43dc88cc77a6ca5e6552c4eb6b160/raw/947458cf230645500f7204e6080bc45b61047d86/invalid-plugin.json&hash=8565d7464877cecc826f0de33b37e91855291d80d16fbdfafd1c617eb85f501062dda8469ccc2566b582cb3d1fb21a3cea86eb1561168b3d4bacfd48fb90659a
  • テーマ (Invalid Theme): /install-extentions?url=https://gist.githubusercontent.com/kakkokari-gtyih/9fa43dc88cc77a6ca5e6552c4eb6b160/raw/fc4f8c3d438ad14bbf176cf6ac67d2a9331f3171/invalid-theme.json&hash=5b5336d868887656d349429b5527f7626a95a80b14ef95290ad5a904d8756bd5d0e75322fa7a1671c60f59e3783106dd356e97cd1d4d9d30d029f631b84c7bd8
  • フェッチエラーについては、クエリパラメータのurlをいじって試してください
  • SHA-512については、クエリパラメータのhashをいじって試してください

エラー画面

image

image

image

image

image

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (2c0a139) 93.92% compared to head (82bb8a7) 79.25%.
Report is 2 commits behind head on develop.

❗ Current head 82bb8a7 differs from pull request most recent head f2b5974. Consider uploading reports for the commit f2b5974 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #12034       +/-   ##
============================================
- Coverage    93.92%   79.25%   -14.67%     
============================================
  Files            2      932      +930     
  Lines          461    99757    +99296     
  Branches        59     8114     +8055     
============================================
+ Hits           433    79066    +78633     
- Misses          28    20691    +20663     
Files Coverage Δ
packages/backend/src/server/api/EndpointsModule.ts 100.00% <100.00%> (ø)
packages/backend/src/server/api/endpoints.ts 100.00% <100.00%> (ø)
packages/frontend/src/components/global/MkUrl.vue 100.00% <100.00%> (ø)
packages/frontend/src/router.ts 99.26% <100.00%> (ø)
...c/server/api/endpoints/fetch-external-resources.ts 73.61% <73.61%> (ø)

... and 925 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

ドキュメンテーション準備完了

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@syuilo syuilo merged commit f51bca4 into misskey-dev:develop Oct 21, 2023
10 of 11 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 21, 2023

👍👍👍

@kakkokari-gtyih kakkokari-gtyih deleted the external-resources branch October 21, 2023 09:41
@kakkokari-gtyih kakkokari-gtyih restored the external-resources branch October 21, 2023 11:31
@kakkokari-gtyih kakkokari-gtyih deleted the external-resources branch October 21, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
2 participants