Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Get api.json from Misskey (get-api-diff)が死んでいるのを修正 #12768

Closed

Conversation

samunohito
Copy link
Member

What

Get api.json from Misskeyが死んでいるのを修正しました。
バージョンアップ時の対応漏れ?

参考:https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

Why

CIが役目を果たさないため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (471c8ec) 79.79% compared to head (f012b9d) 79.79%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #12768   +/-   ##
========================================
  Coverage    79.79%   79.79%           
========================================
  Files          956      956           
  Lines       108800   108800           
  Branches      8373     8374    +1     
========================================
  Hits         86814    86814           
  Misses       21986    21986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samunohito
Copy link
Member Author

えぇ、こけてる

@samunohito
Copy link
Member Author

とおった

@anatawa12
Copy link
Member

report-api-diffの方も変えないといけなさそう

@samunohito
Copy link
Member Author

なるほど、Download artifactの中ですか…
anatawaさんが作られたところみたいなので、お任せしたほうが良さそうです。よろしくお願いします。

@samunohito
Copy link
Member Author

このプルリクの差分としては↓だけなので、こちらはcloseして…
以下の修正を入れた形で新たなプルリクを作っていただけるとスムーズ化と思いました。いかがでしょう?

name: api-artifact-${{ matrix.api-json-name }}

@anatawa12
Copy link
Member

いいと思います。(contributorなので書き込みアクセスもないですし)

@samunohito
Copy link
Member Author

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants