Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): CIが落ちている問題を修正 #12816

Merged
merged 5 commits into from
Dec 27, 2023

Conversation

chocolate-pie
Copy link
Contributor

@chocolate-pie chocolate-pie commented Dec 27, 2023

What

c96bc36 でCIが落ちている問題と、misskeyのセットアップができない問題を修正します。Lint / typecheck (backend)がなぜ落ちているのかわかっていないのでドラフトです(手元では動作している) 動くようになりました

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/misskey-js labels Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e0040f5) 79.98% compared to head (d1fa825) 79.97%.

Files Patch % Lines
.../src/server/api/endpoints/admin/accounts/create.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12816      +/-   ##
===========================================
- Coverage    79.98%   79.97%   -0.01%     
===========================================
  Files          955      955              
  Lines       108793   108791       -2     
  Branches      8413     8412       -1     
===========================================
- Hits         87019    87008      -11     
- Misses       21774    21783       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 27, 2023

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -906,7 +906,7 @@
       "post": {
         "operationId": "admin/accounts/create",
         "summary": "admin/accounts/create",
-        "description": "No description provided.\n\n**Internal Endpoint**: This endpoint is an API for the misskey mainframe and is not intended for use by third parties.\n**Credential required**: *No*",
+        "description": "No description provided.\n\n**Credential required**: *No*",
         "externalDocs": {
           "description": "Source code",
           "url": "https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/endpoints/admin/accounts/create.ts"

Get diff files from Workflow Page

@chocolate-pie
Copy link
Contributor Author

全てのチェックがパスしたのでドラフト解除

@chocolate-pie chocolate-pie marked this pull request as ready for review December 27, 2023 08:34
@syuilo syuilo merged commit a598baa into misskey-dev:develop Dec 27, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 27, 2023

🙏

@chocolate-pie chocolate-pie deleted the fix-security-patch branch December 27, 2023 08:37
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
* fix(test): CIが落ちているのを修正

* fix(ci)?: CIの`typecheck`が落ちる問題を修正

* fix(ci): コンフィグファイルのタイポを修正
madonuko pushed a commit to FyraLabs/nyaakey that referenced this pull request Feb 26, 2024
* fix(test): CIが落ちているのを修正

* fix(ci)?: CIの`typecheck`が落ちる問題を修正

* fix(ci): コンフィグファイルのタイポを修正
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants