Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(backend): ReactionService.prototype.convertLegacyReactions #13375

Merged
merged 10 commits into from
Feb 21, 2024
Merged

refactor(backend): ReactionService.prototype.convertLegacyReactions #13375

merged 10 commits into from
Feb 21, 2024

Commits on Feb 17, 2024

  1. add unit tests

    @okayurisotto
    okayurisotto committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    5787d61 View commit details
    Browse the repository at this point in the history

  2. cleanup unnecessary type assertions

    @okayurisotto
    okayurisotto committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    2fd61db View commit details
    Browse the repository at this point in the history

  3. convertedReaction変数の定義と変換表に対する存在確認処理の整理

    @okayurisotto
    okayurisotto committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    aea54cc View commit details
    Browse the repository at this point in the history

  4. count変数の定義とループ処理でのObject.entries()の活用

    @okayurisotto
    okayurisotto committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    8a44238 View commit details
    Browse the repository at this point in the history

  5. 条件式の整理

    @okayurisotto
    okayurisotto committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    1b69605 View commit details
    Browse the repository at this point in the history

  6. Array.prototype.reduceを使うように

    @okayurisotto
    okayurisotto committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    7d60ae7 View commit details
    Browse the repository at this point in the history

  7. Array.prototype.reduceを使うように

    @okayurisotto
    okayurisotto committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    5f8423c View commit details
    Browse the repository at this point in the history

  8. 配列操作を1つのメソッドチェーンに整理 

    これまでの実装では、`decodeReaction`の返り値が同一になる異なる入力値が同時に複数個存在した場合、後ろのもので上書きされてしまっていたはず。
これからの実装では、後ろのものは前のものに加算される。
（実際にこの挙動の変更が問題になるシチュエーションはまずないはず。）
    @okayurisotto
    okayurisotto committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    0cc3200 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. add unit test

    @okayurisotto
    okayurisotto committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    0bd2465 View commit details
    Browse the repository at this point in the history

  2. ドキュメントコメントの追加と型定義の調整

    @okayurisotto
    okayurisotto committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    eda8c82 View commit details
    Browse the repository at this point in the history