Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: syuilo/misskey時代から使用してるサーバーが改変したバージョンだと誤判定される問題 #13386

Conversation

anatawa12
Copy link
Member

What

Fix #13367

Why

バグ

Additional info (optional)

image

旧URL: bb6cd25#diff-89199e9b67e61349077870168d662c4eb6844c0b56930c809e2490cad67cdc41

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@anatawa12 anatawa12 added this to the [draft] 2024.2.1 milestone Feb 18, 2024
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Feb 18, 2024
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0030d1) 64.48% compared to head (5929f14) 77.52%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13386       +/-   ##
============================================
+ Coverage    64.48%   77.52%   +13.03%     
============================================
  Files          981      185      -796     
  Lines       109999    24787    -85212     
  Branches      5605      463     -5142     
============================================
- Hits         70937    19216    -51721     
+ Misses       37628     5564    -32064     
+ Partials      1434        7     -1427     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acid-chicken
Copy link
Member

DB のマイグレーションの方が良さそう

@anatawa12 anatawa12 changed the title fix: syuilo/misskey時代から使用してるサーバーが改変したバージョンだとご判定される問題 fix: syuilo/misskey時代から使用してるサーバーが改変したバージョンだと誤り判定される問題 Feb 18, 2024
@anatawa12 anatawa12 changed the title fix: syuilo/misskey時代から使用してるサーバーが改変したバージョンだと誤り判定される問題 fix: syuilo/misskey時代から使用してるサーバーが改変したバージョンだと誤判定される問題 Feb 18, 2024
@anatawa12
Copy link
Member Author

DB のマイグレーションの方が良さそう

#13389 にしました。どちらかをマージするという形で

@anatawa12 anatawa12 closed this Feb 19, 2024
@anatawa12 anatawa12 deleted the fix-syuilo-misskey-falsey-detected-as-modified branch February 19, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syuilo/misskeyが外部リポジトリとして認識される
2 participants