feat: 新カスタム絵文字管理画面（β）の追加 #13473
Open
feat: 新カスタム絵文字管理画面（β）の追加 #13473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/misskey-js/src/api.types.ts # packages/misskey-js/src/autogen/apiClientJSDoc.ts # packages/misskey-js/src/autogen/endpoint.ts # packages/misskey-js/src/autogen/entities.ts # packages/misskey-js/src/autogen/models.ts # packages/misskey-js/src/autogen/types.ts
# Conflicts: # packages/frontend/package.json # packages/misskey-js/src/autogen/apiClientJSDoc.ts # packages/misskey-js/src/autogen/endpoint.ts # packages/misskey-js/src/autogen/entities.ts # packages/misskey-js/src/autogen/models.ts # packages/misskey-js/src/autogen/types.ts # pnpm-lock.yaml
# Conflicts: # packages/misskey-js/src/autogen/apiClientJSDoc.ts # packages/misskey-js/src/autogen/endpoint.ts # packages/misskey-js/src/autogen/entities.ts # packages/misskey-js/src/autogen/models.ts # packages/misskey-js/src/autogen/types.ts
|
取り込む |
# Conflicts: # CHANGELOG.md
|
ready for review |
syuilo
reviewed
Aug 19, 2024
syuilo
reviewed
Aug 20, 2024
| }, 100); | ||
| }, { passive: true, once: true }); | ||
| }, { passive: true }); | ||
| nextTick(() => { |
There was a problem hiding this comment.
content.value.children[0]がレンダリング完了前にアクセスするとエラーになるからだと思う
v-ifの都合でまだVDOMに存在しないとかかな
（rerunすれば通る系のfailだけど、ちょいちょい起こるので気になる） |
|
もう少し全体的なUXをブラッシュアップする必要があるわね |
|
引き継ぎます |
|
とりあえずマージした後調整するかしら |
|
9.0に入れるの？（新機能モリモリになるから次でもいい気がしてたけど） |
|
次でいいka |
|
Thank you for sending us a great Pull Request! 👍 example: pnpm run build-misskey-js-with-types |
# Conflicts: # packages/frontend/src/components/MkFolder.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
カスタム絵文字の登録画面をリニューアルし、複数の絵文字に対して同時に登録・更新作業を行えるようにしました。
Why
resolve #10996
Additional info (optional)
既存のカスタム絵文字管理画面はそのままのこし、新画面はβ版の位置づけで追加しています（安定したら完全に置き換える考え）。
Checklist