Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): AnnounceのobjectがNoteでなかったらキューにためない #13553

Closed
wants to merge 8 commits into from

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Mar 9, 2024

Fix #13552

What

  • ApNoteService.validateNoteのエラーにIdentifiableErrorを設定し、InboxProcessorServiceで受け取ったらキューにためないようにする
  • Inboxプロセスで返されてくるreason stringをちゃんとハンドリングする

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Mar 9, 2024
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 2.63158% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 65.07%. Comparing base (f8261a1) to head (9586c3d).
Report is 593 commits behind head on develop.

Files Patch % Lines
...ges/backend/src/core/activitypub/ApInboxService.ts 1.66% 59 Missing ⚠️
...kend/src/queue/processors/InboxProcessorService.ts 0.00% 11 Missing ⚠️
...ckend/src/core/activitypub/models/ApNoteService.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13553       +/-   ##
============================================
- Coverage    79.95%   65.07%   -14.89%     
============================================
  Files          956      989       +33     
  Lines       108864   112500     +3636     
  Branches      8413     5805     -2608     
============================================
- Hits         87045    73208    -13837     
- Misses       21819    39261    +17442     
- Partials         0       31       +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Mar 9, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@tamaina tamaina changed the title fix(federation): AnnounceのobjectがLike出なかったらキューにためない fix(federation): AnnounceのobjectがNoteでなかったらキューにためない Mar 9, 2024
@tamaina
Copy link
Contributor Author

tamaina commented May 28, 2024

@syuilo これはマージしたい

@tamaina tamaina closed this May 28, 2024
@tamaina
Copy link
Contributor Author

tamaina commented May 28, 2024

ん?そうかこれは #13610 に含まれてた

@tamaina tamaina deleted the lem-ann branch May 28, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LemmyがLikeをAnnounceしてくる
2 participants