-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(federation): AnnounceのobjectがNoteでなかったらキューにためない #13553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13553 +/- ##
============================================
- Coverage 79.95% 65.07% -14.89%
============================================
Files 956 989 +33
Lines 108864 112500 +3636
Branches 8413 5805 -2608
============================================
- Hits 87045 73208 -13837
- Misses 21819 39261 +17442
- Partials 0 31 +31 ☔ View full report in Codecov by Sentry. |
このPRによるapi.jsonの差分 差分はこちら |
tamaina
changed the title
fix(federation): AnnounceのobjectがLike出なかったらキューにためない
fix(federation): AnnounceのobjectがNoteでなかったらキューにためない
Mar 9, 2024
mei23
reviewed
Mar 9, 2024
5 tasks
@syuilo これはマージしたい |
ん?そうかこれは #13610 に含まれてた |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13552
What
ApNoteService.validateNote
のエラーにIdentifiableErrorを設定し、InboxProcessorServiceで受け取ったらキューにためないようにするWhy
Additional info (optional)
Checklist