Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

配信停止したインスタンス一覧が見れなくなる問題を修正 #13945

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

GrapeApple0
Copy link
Contributor

What

インスタンス一覧で配信停止でフィルターをかけると一覧が見れなくなる問題を修正しました

Why

fix: #13930

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link
Contributor

@tai-cha tai-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます👍🏻

yunochi added a commit to serafuku/misskey that referenced this pull request Jun 4, 2024
@tai-cha
Copy link
Contributor

tai-cha commented Jun 6, 2024

ApproveしたけどCHANGELOGないですねそういえば

Copy link
Contributor

@tai-cha tai-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG足していただけると助かります
(もし御多忙でしたら代わりに私がやるのでもよいのでその場合は仰っていただければ)

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.21%. Comparing base (8f833d7) to head (ffb87dd).

Files Patch % Lines
...d/src/server/api/endpoints/federation/instances.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13945      +/-   ##
===========================================
- Coverage    65.01%   63.21%   -1.80%     
===========================================
  Files          989      987       -2     
  Lines       112995   112805     -190     
  Branches      5790     4213    -1577     
===========================================
- Hits         73460    71313    -2147     
- Misses       38093    41461    +3368     
+ Partials      1442       31    -1411     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit e0cf5b2 into misskey-dev:develop Jun 7, 2024
26 checks passed
@syuilo
Copy link
Member

syuilo commented Jun 7, 2024

🙏🏻

@GrapeApple0 GrapeApple0 deleted the 13930 branch June 7, 2024 13:08
anatawa12 pushed a commit to anatawa12/misskey that referenced this pull request Jun 20, 2024
* 配信停止したインスタンス一覧が見れなくなる問題を修正

* Update CHANGELOG.md
adzukimame pushed a commit to adzukimame/misskey that referenced this pull request Jun 28, 2024
* 配信停止したインスタンス一覧が見れなくなる問題を修正

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

インスタンス一覧で配信停止でフィルターを掛けるとエラーが出る
3 participants