Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): iOSでacctなどがリンクとして誤検知されるのを抑制 #14354

Merged
merged 6 commits into from
Aug 10, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Aug 2, 2024

What

meta format-detection tag を追加

Why

  • Acctが出現する箇所 (タイムラインのノート、プロフィール、オートコンプリートなど)
  • プレビュー(要素が破壊されるので動作しなくなる)

ref: https://misskey.io/notes/9wg6ij33cb0b00hp

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@kakkokari-gtyih kakkokari-gtyih changed the title fix(frontend): iosでacctなどがリンクとして誤検知されるのを抑制 fix(frontend): iOSでacctなどがリンクとして誤検知されるのを抑制 Aug 2, 2024
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Aug 2, 2024
Copy link
Contributor

github-actions bot commented Aug 2, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.91%. Comparing base (7e3dedb) to head (c7129e2).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14354       +/-   ##
============================================
+ Coverage    20.24%   39.91%   +19.66%     
============================================
  Files          723     1545      +822     
  Lines       100289   190495    +90206     
  Branches      1049     3549     +2500     
============================================
+ Hits         20308    76029    +55721     
- Misses       79440   113875    +34435     
- Partials       541      591       +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.8.0 milestone Aug 8, 2024
@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@syuilo syuilo merged commit cb10156 into misskey-dev:develop Aug 10, 2024
26 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 10, 2024

🙏🏻

@kakkokari-gtyih kakkokari-gtyih deleted the fix-ios-linkautodetect branch August 10, 2024 12:08
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
* fix(frontend): iosでの自動リンク化を抑制

* Update Changelog

* typo

* typo

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants