fix(frontend): リノートの判定が甘いのを修正 #14396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14396 +/- ##
===========================================
+ Coverage 39.91% 41.65% +1.73%
===========================================
Files 1545 1550 +5
Lines 190531 196560 +6029
Branches 2701 2692 -9
===========================================
+ Hits 76054 81874 +5820
- Misses 113916 114123 +207
- Partials 561 563 +2 ☔ View full report in Codecov by Sentry. |
zyoshoka
reviewed
Aug 12, 2024
|
👀 |
|
こぬふりくと解消 |
syuilo
reviewed
Aug 17, 2024
packages/misskey-js/src/note.ts
Outdated
| @@ -0,0 +1,12 @@ | |||
| import type { Note, Renote } from './entities.js'; | |||
|
|
|||
| export function isRenote(note: Note): note is Renote { | |||
There was a problem hiding this comment.
型の名前もPureRenoteにしておく？
|
🙏🏿 |
LemonDouble
pushed a commit
to LemonDouble/misskey
that referenced
this pull request
Aug 19, 2024
* fix(frontend): リノートの判定が甘いのを修正 * fix * Update Changelog * fix * use type assertion * fix + add comments * lint * misskey-jsに移動 * PureRenote -> Renote * isRenote -> isPureRenote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Fix https://misskey.io/notes/9wueduyg27vy0437
一部の自ノートで削除ボタンが出ないのを修正
Additional info (optional)
Checklist