Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): remove stale reload method call on /admin/users page #14406

Merged

Conversation

zyoshoka
Copy link
Contributor

What

/admin/users ページに残っている不要なメソッド呼び出しを削除します。

Why

5c5d3c1#diff-2ef64414b49d081dda4ce08eeced24033bcf5e4f36091700964a89b43be1fcc6L39-R39 の際に書き換え変え忘れたからか、入力欄を更新した際にコンソールに次のようなエラーが出るようになっている上に、別になくても更新されるため

[Vue warn]: Error in https://vuejs.org/error-reference/#runtime-6: "TypeError: can't access property "reload", i.$refs.users is undefined"

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 20.25%. Comparing base (41936c1) to head (0b804c7).
Report is 1 commits behind head on develop.

Files Patch % Lines
packages/frontend/src/pages/admin/users.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14406       +/-   ##
============================================
- Coverage    39.91%   20.25%   -19.67%     
============================================
  Files         1545      723      -822     
  Lines       190505   100283    -90222     
  Branches      2654     1049     -1605     
============================================
- Hits         76046    20308    -55738     
+ Misses      113898    79434    -34464     
+ Partials       561      541       -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit b68b2ee into misskey-dev:develop Aug 14, 2024
16 of 17 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 14, 2024

🙏🏻

@zyoshoka zyoshoka deleted the remove-outdated-reload-method-call branch August 14, 2024 13:05
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants