Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misskey-js): eliminate any (follow-up of #13523) #14422

Merged

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Aug 17, 2024

What

Why

Additional info (optional)

related: #13523

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@syuilo syuilo merged commit 83c04c5 into misskey-dev:develop Aug 17, 2024
13 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 17, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the fix-eliminate-misskey-js-any-1 branch August 17, 2024 09:16
Copy link
Collaborator

@KisaragiEffective KisaragiEffective left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.70%. Comparing base (c0de57c) to head (f267463).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14422      +/-   ##
===========================================
+ Coverage    38.75%   41.70%   +2.95%     
===========================================
  Files         1547     1551       +4     
  Lines       190878   196934    +6056     
  Branches      3263     2770     -493     
===========================================
+ Hits         73969    82130    +8161     
+ Misses      116310   114242    -2068     
+ Partials       599      562      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants