Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misskey-js): content-typeはapplication/jsonでないもののみを記録するように #14508

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

  • content-typeはapplication/jsonでないもののみを記録するように
  • content-type が判別できない場合はapplication/jsonをデフォルトにするように

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review September 6, 2024 05:44
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.57%. Comparing base (3fe7e37) to head (f02f28b).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14508       +/-   ##
============================================
+ Coverage    20.17%   41.57%   +21.39%     
============================================
  Files          725     1551      +826     
  Lines       100502   196640    +96138     
  Branches      1045     2737     +1692     
============================================
+ Hits         20279    81750    +61471     
- Misses       79681   114328    +34647     
- Partials       542      562       +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 8d19bdb into misskey-dev:develop Sep 6, 2024
24 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 6, 2024

🙏🏿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

misskey-js: fallback to Content-Type: application/json for unknown endpoints
2 participants