Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): adminのファイルリストでセンシティブファイルに枠線を追加 #14510

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Sep 6, 2024

What

image

Why

Fix #14389

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 19.99%. Comparing base (f7398fa) to head (11cc4a8).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
...ges/frontend/src/components/MkFileListForAdmin.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14510      +/-   ##
===========================================
+ Coverage    19.97%   19.99%   +0.01%     
===========================================
  Files          725      725              
  Lines       100569   100588      +19     
  Branches      1047     1047              
===========================================
+ Hits         20089    20108      +19     
  Misses       79936    79936              
  Partials       544      544              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KisaragiEffective KisaragiEffective left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@syuilo syuilo merged commit 0e4b6d1 into misskey-dev:develop Sep 15, 2024
18 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 15, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the enh-14389 branch September 15, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
3 participants