Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mk:C:containerのborderStyleとborderRadiusを設定できるように #14638

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

FineArchs
Copy link
Contributor

@FineArchs FineArchs commented Sep 27, 2024

What

AiScriptのMk:C:containerのオプションにborderStyleとborderRadiusを追加し、枠線のスタイルと丸みを指定できるようにします。
borderRadiusとroundedが両方指定された場合、borderRadiusが優先されます。
また、borderWidth, borderColor, borderStyleのうち一つでも指定があれば枠線が可視化されるようになります。

Why

#14289

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 19.43%. Comparing base (d8a2eeb) to head (a28bfbd).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/components/MkAsUi.vue 0.00% 25 Missing ⚠️
packages/frontend/src/scripts/aiscript/ui.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14638       +/-   ##
============================================
- Coverage    41.28%   19.43%   -21.86%     
============================================
  Files         1548      715      -833     
  Lines       199120   101274    -97846     
  Branches      2604      986     -1618     
============================================
- Hits         82202    19680    -62522     
+ Misses      116353    81048    -35305     
+ Partials       565      546       -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 25670b5 into misskey-dev:develop Sep 28, 2024
22 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 28, 2024

🙏🏻

@FineArchs FineArchs deleted the container-border branch September 28, 2024 01:49
@kakkokari-gtyih
Copy link
Contributor

Misskey Hubにドキュメント追加する必要がある

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ui:C:container() で borderWidth, borderColor を指定しても枠線が表示されない
3 participants