Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misskey js autogen check improvements #14652

Merged
merged 2 commits into from
Oct 3, 2024
+7 −1
Merged

Misskey js autogen check improvements #14652

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8f357c
ci: Make failure if misskey js autogen detected changes
anatawa12 Sep 30, 2024
5513948
ci: set persist-credentials
anatawa12 Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/check-misskey-js-autogen.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
uses: actions/checkout@v4.1.1
with:
submodules: true
persist-credentials: false
ref: refs/pull/${{ github.event.pull_request.number }}/merge

- name: setup pnpm
Expand Down Expand Up @@ -57,7 +58,7 @@ jobs:
name: generated-misskey-js
path: packages/misskey-js/generator/built/autogen

# pull_request_target safety: permissions: read-all, and there are no secrets used in this job
# pull_request_target safety: permissions: read-all, and no user codes are executed
get-actual-misskey-js:
runs-on: ubuntu-latest
permissions:
Expand All @@ -68,6 +69,7 @@ jobs:
uses: actions/checkout@v4.1.1
with:
submodules: true
persist-credentials: false
ref: refs/pull/${{ github.event.pull_request.number }}/merge

- name: Upload From Merged
Expand Down Expand Up @@ -131,3 +133,7 @@ jobs:
mode: delete
message: "Thank you!"
create_if_not_exists: false

- name: Make failure if changes are detected
if: steps.check-changes.outputs.changes == 'true'
run: exit 1