fix(gh): Githubのテスト用環境でsetupPasswordが指定されていないのを修正 #14681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍🏻 |
jbblily
added a commit
to jbblily/misskey
that referenced
this pull request
Oct 22, 2024
* [skip ci] Update CHANGELOG.md (prepend template) * enhance(frontend): フォロワーへのメッセージ欄を改良 (misskey-dev#14656) * enhance(frontend): フォロワーへのメッセージ欄を改良 * Update Changelog * 🎨 * fix(misskey-js): build misskey-js with types (misskey-dev#14665) * Make post form attachments accessible (misskey-dev#14666) * fix(frontend): Make post form attachments accessible Adds a role="button", tabindex, and @keydown to MkPostFormAttaches in order to make it accessible to keyboard users. * Fix for linter * Add spacing in type signature * fix: sassのmodern-compilerを使うように (misskey-dev#14651) * fix(frontend-embed): ビルド時にsassのmodern-compilerを使うように * fix(frontend): ビルド時にsassのmodern-compilerを使うように * Misskey js autogen check improvements (misskey-dev#14652) * ci: Make failure if misskey js autogen detected changes * ci: set persist-credentials * enhance: require captcha for signin (misskey-dev#14655) * wip * Update MkSignin.vue * Update MkSignin.vue * wip * Update CHANGELOG.md * update deps * enhance(backend): notify new login (misskey-dev#14673) * wip * Update CHANGELOG.md * wip * fix * Update index.d.ts * Update SigninService.ts * Update MkNotification.vue * fix(frontend): データセーバーを有効にしているときにメンションのアイコンがアニメーションしないように (misskey-dev#14674) * refactor & performance improvements of MkMention * Bump version to 2024.10.0-alpha.0 * New Crowdin updates (misskey-dev#14649) * New translations ja-jp.yml (Catalan) * New translations ja-jp.yml (Catalan) * New translations ja-jp.yml (English) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (English) * New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (Korean) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (Catalan) * New translations ja-jp.yml (Italian) * New translations ja-jp.yml (Catalan) * New translations ja-jp.yml (Italian) * New translations ja-jp.yml (Romanian) * New translations ja-jp.yml (French) * New translations ja-jp.yml (Spanish) * New translations ja-jp.yml (Arabic) * New translations ja-jp.yml (Czech) * New translations ja-jp.yml (German) * New translations ja-jp.yml (Greek) * New translations ja-jp.yml (Hungarian) * New translations ja-jp.yml (Korean) * New translations ja-jp.yml (Dutch) * New translations ja-jp.yml (Norwegian) * New translations ja-jp.yml (English) * New translations ja-jp.yml (Portuguese) * New translations ja-jp.yml (Russian) * New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (Indonesian) * New translations ja-jp.yml (Polish) * New translations ja-jp.yml (Slovak) * New translations ja-jp.yml (Swedish) * New translations ja-jp.yml (Turkish) * New translations ja-jp.yml (Ukrainian) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (Vietnamese) * New translations ja-jp.yml (Bengali) * New translations ja-jp.yml (Thai) * New translations ja-jp.yml (Uyghur) * New translations ja-jp.yml (Sinhala) * New translations ja-jp.yml (Uzbek) * New translations ja-jp.yml (Kannada) * New translations ja-jp.yml (Lao) * New translations ja-jp.yml (Japanese, Kansai) * New translations ja-jp.yml (Korean (Gyeongsang)) * fix(backend): 連合限定先が間違って連合しない先に代入されているのを修正 (misskey-dev#14662) * fix(backend): 連合限定先が間違って連合しない先に代入されているのを修正 * build: fix property typo * Update CHANGELOG.md * Update CHANGELOG.md * feat: サーバー初期設定時に初期パスワードを要求できるように (misskey-dev#14626) * feat: サーバー初期設定時専用の初期パスワードを設定できるように * 無いのに入力された場合もエラーにする * 🎨 * 🎨 * cypress-devcontainerにもpassを設定（テストが失敗するため） * [ci skip] 🎨 * ✌️ * test: please revert this commit before merge * Revert "test: please revert this commit before merge" This reverts commit 66b2b48. * Update locales/ja-JP.yml Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com> * build assets * Update Changelog * fix condition * fix condition * add comment * change error code * 他のエラーコードと合わせる * Update CHANGELOG.md --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com> * fix(misskey-js): type fixes related to signup and signin (misskey-dev#14679) * initialPassword -> setupPassword * fix(gh): Githubのテスト用環境でsetupPasswordが指定されていないのを修正 (misskey-dev#14681) * fix: 初期パスワードをコメントアウト (misskey-dev#14682) * fix: 初期パスワードをコメントアウト * 🎨 * fix indent * Bump version to 2024.10.0-alpha.1 * Bump version to 2024.10.0-beta.2 * fix(test): 初期セットアップで初期パスワードを入力していないのを修正 (misskey-dev#14685) * 🎨 * update deps * 🎨 * 🎨 * fix test * Update generate.tsx * enhance(frontend): サインイン画面の改善 (misskey-dev#14658) * wip * Update MkSignin.vue * Update MkSignin.vue * wip * Update CHANGELOG.md * enhance(frontend): サインイン画面の改善 * Update Changelog * 14655の変更取り込み * spdx * fix * fix * fix * 🎨 * 🎨 * 🎨 * 🎨 * Captchaがリセットされない問題を修正 * 次の処理をsignin apiから読み取るように * Add Comments * fix * fix test * attempt to fix test * fix test * fix test * fix test * fix * fix test * fix: 一部のエラーがちゃんと出るように * Update Changelog * 🎨 * 🎨 * remove border --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com> * Bump version to 2024.10.0-beta.3 * fix(frontend): リンク動作のオーバーライドが動作していないのを修正 * 🎨 * 🎨 * fix(frontend): canvas-confettiの型定義を追加 (misskey-dev#14692) * New Crowdin updates (misskey-dev#14677) * New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (Korean) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (English) * New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (Korean) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (Chinese Simplified) * Bump version to 2024.10.0-beta.4 * fix(frontend): ログイン画面でキャプチャが表示されない問題を修正 (misskey-dev#14694) * fix(frontend): ログイン画面でキャプチャが表示されない問題を修正 * rename * 🎨 * fix: signin の資格情報が足りないだけの場合はエラーにせず200を返すように (misskey-dev#14700) * fix: signin の資格情報が足りないだけの場合はエラーにせず200を返すように * run api extractor * fix * fix * fix test * /signin -> /signin-flow * fix * fix lint * rename * fix * fix * feat(backend): 通報および通報解決時に送出されるSystemWebhookにユーザ情報を含めるようにする (misskey-dev#14698) * feat(backend): 通報および通報解決時に送出されるSystemWebhookにユーザ情報を含めるようにする * テスト送信もペイロード形式を合わせる * add spaces * fix test * misskey-dev#14675 レビューの修正 (misskey-dev#14705) * enhance: 人気のPlayを10件以上表示できるように (misskey-dev#14443) Co-authored-by: osamu <46447427+sam-osamu@users.noreply.github.com> * 🎨 * feat: 通報の強化 (misskey-dev#14704) * wip * Update CHANGELOG.md * lint * Update types.ts * wip * ✌️ * Update MkAbuseReport.vue * tweak * fix(backend/test): misskey-dev#14558 以降e2eテストがたまに失敗する問題を修正 (misskey-dev#14709) * fix(backend/test): MisskeyIO#727 以降e2eテストがたまに失敗する問題を修正 (MisskeyIO#735) * ✌️ --------- Co-authored-by: まっちゃとーにゅ <17376330+u1-liquid@users.noreply.github.com> * Bump version to 2024.10.0-beta.5 * 🎨 * fix of d8cb730 * fix(backend): correct `admin/abuse-user-reports` schema (misskey-dev#14711) * fix(backend): correct `abuse-user-reports` schema * Update CHANGELOG.md * 🎨 * make animatedMfm enable by default * fix(frontend): クライアント上での時間ベースの実績獲得動作が実績獲得後も発動している問題を修正 (misskey-dev#14717) * Check if time-based achievements are unlocked before initializing them in main-boot (cherry picked from commit c0702fd) * Update Changelog --------- Co-authored-by: Evan Paterakis <evan@geopjr.dev> * Update packages/frontend/src/store.ts Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com> * New Crowdin updates (misskey-dev#14695) * New translations ja-jp.yml (Italian) * New translations ja-jp.yml (Korean) * New translations ja-jp.yml (Catalan) * New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (English) * New translations ja-jp.yml (Portuguese) * New translations ja-jp.yml (Catalan) * New translations ja-jp.yml (Italian) * New translations ja-jp.yml (Russian) * New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (Indonesian) * New translations ja-jp.yml (Romanian) * New translations ja-jp.yml (French) * New translations ja-jp.yml (Spanish) * New translations ja-jp.yml (Arabic) * New translations ja-jp.yml (Czech) * New translations ja-jp.yml (German) * New translations ja-jp.yml (Korean) * New translations ja-jp.yml (Polish) * New translations ja-jp.yml (Slovak) * New translations ja-jp.yml (Ukrainian) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (Vietnamese) * New translations ja-jp.yml (Bengali) * New translations ja-jp.yml (Thai) * New translations ja-jp.yml (Uzbek) * New translations ja-jp.yml (Japanese, Kansai) * New translations ja-jp.yml (Korean (Gyeongsang)) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (Korean) * New translations ja-jp.yml (Korean) * refactor: 拡張機能インストールのページの一部をコンポーネントとして分離 (misskey-dev#14654) * create MkExtensionInstaller.vue * annotation * add fallbacks * storybook * update annotations * Update MkExtensionInstaller.vue * use additonalInfo slot * Bump version to 2024.10.0-beta.6 * New Crowdin updates (misskey-dev#14722) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (Chinese Simplified) * Update packages/frontend/src/store.ts Co-authored-by: anatawa12 <anatawa12@icloud.com> * New Crowdin updates (misskey-dev#14723) * New translations ja-jp.yml (English) * New translations ja-jp.yml (English) * New translations ja-jp.yml (Portuguese) * New translations ja-jp.yml (Chinese Simplified) * Update packages/backend/src/core/entities/FlashEntityService.ts Co-authored-by: zyoshoka <107108195+zyoshoka@users.noreply.github.com> * Update packages/frontend/src/components/MkAbuseReport.vue Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com> * build(deps): bump actions/cache from 4.0.2 to 4.1.0 (misskey-dev#14718) Bumps [actions/cache](https://github.com/actions/cache) from 4.0.2 to 4.1.0. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4.0.2...v4.1.0) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 🎨 * Update CHANGELOG.md * Release: 2024.10.0 * [skip ci] Update CHANGELOG.md (prepend template) * refactor(frontend): prefix css variables (misskey-dev#14725) * wip * Update index.d.ts * remove unnecessary codes * fix(frontend): ユーザー登録完了時にサインインAPIを別途使用していたのを修正 (misskey-dev#14738) * fix(frontend): ユーザー登録完了時にサインインAPIを別途使用していたのを修正 * emitされるオブジェクトの型を変更したことに伴う修正 * Update Changelog * New Crowdin updates (misskey-dev#14733) * New translations ja-jp.yml (English) * New translations ja-jp.yml (Portuguese) * New translations ja-jp.yml (Catalan) * New translations ja-jp.yml (Italian) * New translations ja-jp.yml (Russian) * New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (Indonesian) * New translations ja-jp.yml (French) * New translations ja-jp.yml (Spanish) * New translations ja-jp.yml (Arabic) * New translations ja-jp.yml (Czech) * New translations ja-jp.yml (German) * New translations ja-jp.yml (Korean) * New translations ja-jp.yml (Polish) * New translations ja-jp.yml (Slovak) * New translations ja-jp.yml (Ukrainian) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (Vietnamese) * New translations ja-jp.yml (Bengali) * New translations ja-jp.yml (Thai) * New translations ja-jp.yml (Japanese, Kansai) * New translations ja-jp.yml (Catalan) * Bump version to 2024.10.1-alpha.0 * Bump version to 2024.10.1-beta.1 * refactor(frontend): prefix css variables (UI) (misskey-dev#14739) * refactor(frontend): prefix css variables * `MI_UI` -> `MI` * fix * `stickyBottom` * stickyTop * clean up * 🎨 * Update CHANGELOG.md * Bump version to 2024.10.1-beta.2 * clean up * Update CHANGELOG.md (書き方を揃える) * fix: admin/emoji/update で不正なエラーが発生する (misskey-dev#14750) * fix emoji updating bug * update changelog * type fix * " -> ' * conprehensiveness check * lint * undefined -> null * feat(backend): 7日間運営のアクティビティがないサーバを自動的に招待制にする (misskey-dev#14746) * feat(backend): 7日間運営のアクティビティがないサーバを自動的に招待制にする * fix RoleService. * fix * fix * fix * add test and fix * fix * fix CHANGELOG.md * fix test * chore: add description * wip (misskey-dev#14745) * Bump version to 2024.10.1-beta.3 * fix(backend): キューのエラーログを簡略化するように (misskey-dev#14748) * reduce federation log spam * Don't record stack trace for unrecoverable errors. * Avoid logging duplicate stace traces. (cherry picked from commit ed05701) * improve error summaries (cherry picked from commit 20dd66f) * fix lint errors (cherry picked from commit 83869e1) * condense job info (cherry picked from commit 786702e) * fix maxAttempts calculation (cherry picked from commit b4d10aa) * condense error info (cherry picked from commit f62cd89) * normalize ID logging (cherry picked from commit d8e1e48) * further condense error details (cherry picked from commit d867c20) * collapse AbortErrors (cherry picked from commit 5171ba7) * don't log job name unless it has one (cherry picked from commit a5316c0) * Update Changelog * Record origin --------- Co-authored-by: Hazel K <acomputerdog@gmail.com> * Update about-misskey.vue * Update index.d.ts * fix(frontend): fix style Fix misskey-dev#14754 * 🎨 * refactor: MkStickyContainerで<style />を使う (misskey-dev#14755) * remove rootEL ref * use css module * use v-bind in css * --MI prefix * remove unused ref --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com> * 🎨 * feat: ユーザーの名前に禁止ワードを設定できるように (misskey-dev#14756) * wip * 🎨 * Enhance: モデレーター以上は制限の影響を受けないように * refactor * better error handling * fix * Revert "better error handling" This reverts commit 5670b29. * error handling * エラーが出ないのを修正 * translation * Update Changelog * status code * ✌️ * モデレーター以上は影響ないことを明記 * 🎨 * update changelog * spdx * Update update.ts * refactor * eliminate `screen name` * remove untracked file --------- Co-authored-by: KanariKanaru <93921745+kanarikanaru@users.noreply.github.com> * feat: リモートサーバーのサーバー情報を収集しないオプション (misskey-dev#14634) * wip * wip * Update FetchInstanceMetadataService.ts * Update FetchInstanceMetadataService.ts * Update types.ts * refactor(backend): remove unnecessary .then * feat: 運営のアクティビティが一定期間ない場合は通知＋招待制に移行した際に通知 (misskey-dev#14757) * feat: 運営のアクティビティが一定期間ない場合は通知＋招待制に移行した際に通知 * fix misskey-js.api.md * Revert "feat: 運営のアクティビティが一定期間ない場合は通知＋招待制に移行した際に通知" This reverts commit 3ab953b. * 通知をやめてユーザ単位でのお知らせ機能に変更 * テスト用実装を戻す * Update packages/backend/src/queue/processors/CheckModeratorsActivityProcessorService.ts Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com> * fix remove empty then --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com> * Bump version to 2024.10.1-beta.4 * fix(frontend): 使用されているexposeを復活させる (misskey-dev#14764) * fix(frontend): タイムラインで、広告がない際にも広告のwrapperが出てしまうのを修正 (misskey-dev#14763) * fix(backend): RBT有効時、リノートのリアクションが反映されない問題を修正 * perf(frontend): ノートのレンダリングをスキップできるように * New Crowdin updates (misskey-dev#14753) * New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (Korean) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (Catalan) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (Korean) * New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (Italian) * New translations ja-jp.yml (Italian) * enhance(backend): 個人宛のお知らせはわかったを押すとアーカイブするように (misskey-dev#14762) * enhance(backend): 個人宛のお知らせはわかったを押すとアーカイブするように * Update Changelog * enhance(frontend): アーカイブ済みのものを読み込めるように * Update Changelog * fix changelog * 🎨 * Bump version to 2024.10.1-beta.5 * perf(frontend): improve notification rendering performance * perf(frontend-embed): improve note rendering performance * perf(frontend): make skipNoteRender on by default * Update CHANGELOG.md * Bump version to 2024.10.1-beta.6 * 🎨 * refactor * Revert "refactor" This reverts commit 7fd8ef3. * refactor(backend): remove unnecessary any * add note * add note * Update CHANGELOG.md * Update CHANGELOG.md * fix(frontend): blinkアニメーションが動作していないのを修正 * test(backend): add federation test (misskey-dev#14582) * test(backend): add federation test * fix(ci): install pnpm * fix(ci): cd * fix(ci): build entire project * fix(ci): skip frontend build * fix(ci): pull submodule when checkout * chore: show log for debugging * Revert "chore: show log for debugging" This reverts commit a930964. * fix(ci): build entire project * chore: omit unused globals * refactor: use strictEqual and simplify some asserts * test: follow requests * refactor: add resolveRemoteNote function * refactor: refine resolveRemoteUser function * refactor: cache admin credentials * refactor: simplify assertion with excluded fields * refactor: use assert * test: note * chore: labeler detect federation * test: blocking * test: move * fix: use appropriate TLD * chore: shorter purge interval * fix(ci): change TLD * refactor: delete trivial comment * test(user): isCat * chore: use jest * chore: omit logs * chore: add memo * fix(ci): omit unnecessary build * test: pinning Note * fix: build daemon in container * style: indent * test(streaming): timeline * chore: rename * fix: delete role after test * refactor: resolve users by uri * fix: delete antenna after test * test: api timeline * test: Note deletion * refactor: sleep function * test: notification * style: indent * refactor: type-safe host * docs: update description * refactor: resolve function params * fix(block): wrong test name * fix: invalid type * fix: longer timeout for fire testing * test(timeline): hashtag * test(note): vote delivery * fix: wrong description * fix: hashtag channel param type * refactor: wrap basic cases * test(timeline): add homeTimeline tests * fix(timeline): correct wrong case and description * test(notification): add tests for Note * refactor(user): wrap profile consistency with describe * chore(note): add issue link * test(timeline): add test * test(user): suspension * test: emoji * refactor: fetch admin first * perf: faster tests * test(drive): sensitive flag * test(emoji): add tests * chore: ignore .config/docker.env * chore: hard-coded tester IP address * test(emoji): custom emoji are surrounded by zero width space * refactor: client and username as property * test(notification): mute * fix(notification): correct description * test(block): mention * refactor(emoji): addCustomEmoji function * fix: typo * test(note): add reaction tests * test(timeline): Note deletion * fix: unnecessary ts-expect-error * refactor: unnecessary fetch mocking * chore: add TODO comments * test(user): deletion * chore: enable --frozen-lockfile * fix(ci): copying configs * docs: update CONTRIBUTING.md * docs: fix typo * chore: set default sleep duration * fix(notification): omit flaky tests * fix(notification): correct type * test(notification): add api endpoint tests * chore: remove redundant mute test * refactor: use param client * fix: start timer after trigger * refactor: remove unnecessary any * chore: shorter timeout for checking if fired * fix(block): remove outdated comment * refactor: shorten remote user variable name * refactor(block): use existing function * refactor: file upload * docs: update description * test(user): ffVisibility * fix: `/api/signin` -> `/api/signin-flow` * test: abuse report * refactor: use existing type * refactor: extract duplicate configs to template file * fix: typo * fix: avoid conflict * refactor: change container dependency * perf: start misskey parallelly * fix: remove dependency * chore(backend): add typecheck * test: add check for misskey-dev#14728 * chore: enable eslint check * perf: don't start linked services when test * test(note): remote note deletion for moderation * chore: define config template * chore: write setup script * refactor: omit unnecessary conditional * refactor: clarify scope * refactor: omit type assertion * refactor: omit logs * style * refactor: redundant promise * refactor: unnecessary imports * refactor: use readable error code * refactor: cache set in signin function * refactor: optimize import * Release: 2024.10.1 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com> Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com> Co-authored-by: Julia <julia@insertdomain.name> Co-authored-by: 甘瀬ここあ <amase.cocoa@gmail.com> Co-authored-by: anatawa12 <anatawa12@icloud.com> Co-authored-by: Kisaragi <48310258+KisaragiEffective@users.noreply.github.com> Co-authored-by: zyoshoka <107108195+zyoshoka@users.noreply.github.com> Co-authored-by: おさむのひと <46447427+samunohito@users.noreply.github.com> Co-authored-by: osamu <46447427+sam-osamu@users.noreply.github.com> Co-authored-by: まっちゃとーにゅ <17376330+u1-liquid@users.noreply.github.com> Co-authored-by: Evan Paterakis <evan@geopjr.dev> Co-authored-by: FineArchs <133759614+FineArchs@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: misskey-release-bot[bot] <157398866+misskey-release-bot[bot]@users.noreply.github.com> Co-authored-by: Hazel K <acomputerdog@gmail.com> Co-authored-by: KanariKanaru <93921745+kanarikanaru@users.noreply.github.com>
liumingye
pushed a commit
to liumingye/misskey
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
fix #14626 (comment)
Additional info (optional)
Checklist