Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): 瞬間的にstreamから切断された場合にもstream indicatorが出てしまうのを修正 #14832

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Oct 24, 2024

What

一瞬切れただけでも出てしまうのはうざい可能性がある
あと再接続されても消えなかったのでそれも修正

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 19.39%. Comparing base (db95b6b) to head (1c5503d).

Files with missing lines Patch % Lines
...ages/frontend/src/ui/_common_/stream-indicator.vue 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14832       +/-   ##
============================================
- Coverage    38.37%   19.39%   -18.98%     
============================================
  Files         1557      724      -833     
  Lines       196633   103230    -93403     
  Branches      3308      992     -2316     
============================================
- Hits         75460    20026    -55434     
+ Misses      120563    82653    -37910     
+ Partials       610      551       -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants