-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Unable to crop avatar in some cases #14844
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14844 +/- ##
============================================
- Coverage 39.47% 19.15% -20.33%
============================================
Files 1559 726 -833
Lines 196944 103475 -93469
Branches 3616 996 -2620
============================================
- Hits 77747 19820 -57927
+ Misses 118591 83100 -35491
+ Partials 606 555 -51 ☔ View full report in Codecov by Sentry. |
In my use case, it is displaying the instance domain name instead of the current domain name, so the feature doesn't work. |
Are you running the frontend on a separate domain from the backend? That's not the vanila Misskey behavior and is not guaranteed to work. |
My use case is to reverse proxy Misskey on a different domain than the one set up |
Well, afaik that is not guaranteed to work |
In fact, this type of use case is working basically well at the moment, and this PR is an attempt to make it work even better. |
Any other issues preventing it from being merged please? |
What
close #14843
Why
#14843
Additional info (optional)
Checklist