Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unable to crop avatar in some cases #14844

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

MomentQYC
Copy link
Contributor

What

close #14843

Why

#14843

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 26, 2024
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 19.15%. Comparing base (224bbd4) to head (d8a29a5).

Files with missing lines Patch % Lines
...ckages/frontend/src/components/MkCropperDialog.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14844       +/-   ##
============================================
- Coverage    39.47%   19.15%   -20.33%     
============================================
  Files         1559      726      -833     
  Lines       196944   103475    -93469     
  Branches      3616      996     -2620     
============================================
- Hits         77747    19820    -57927     
+ Misses      118591    83100    -35491     
+ Partials       606      555       -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Oct 26, 2024

image

The third argument is a flag to force the same origin, so it should be working as-is.
At least, we should investigate the reason why images cannot be fetched from the same origin despite this flag, rather than trying to fix it in a minor way.

@MomentQYC
Copy link
Contributor Author

The third argument is a flag to force the same origin, so it should be working as-is.

In my use case, it is displaying the instance domain name instead of the current domain name, so the feature doesn't work.

@MomentQYC
Copy link
Contributor Author

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Oct 26, 2024

The third argument is a flag to force the same origin, so it should be working as-is.

In my use case, it is displaying the instance domain name instead of the current domain name, so the feature doesn't work.

Are you running the frontend on a separate domain from the backend? That's not the vanila Misskey behavior and is not guaranteed to work.

@MomentQYC
Copy link
Contributor Author

Are you running the frontend on a separate domain from the backend? That's not the vanila Misskey behavior and is not guaranteed to work.

My use case is to reverse proxy Misskey on a different domain than the one set up

@kakkokari-gtyih
Copy link
Contributor

Are you running the frontend on a separate domain from the backend? That's not the vanila Misskey behavior and is not guaranteed to work.

My use case is to reverse proxy Misskey on a different domain than the one set up

Well, afaik that is not guaranteed to work

@MomentQYC
Copy link
Contributor Author

Well, afaik that is not guaranteed to work

In fact, this type of use case is working basically well at the moment, and this PR is an attempt to make it work even better.

@MomentQYC
Copy link
Contributor Author

Well, afaik that is not guaranteed to work

Any other issues preventing it from being merged please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to crop avatar in some cases
2 participants