Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): ワードミュートで引っかかったワードを表示可能にする #15195

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

tai-cha
Copy link
Contributor

@tai-cha tai-cha commented Dec 31, 2024

What

image
image
image

デフォルトでオフですが、オンにすることで検知されたワードを表示できるようになります

Why

#15194
ハードワードミュートとの差別化

Additional info (optional)

Cherry-picked from nadesskey#57

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 31, 2024
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 20 lines in your changes missing coverage. Please review.

Project coverage is 20.00%. Comparing base (79b851f) to head (764c6c3).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...ackages/frontend/src/pages/settings/mute-block.vue 0.00% 13 Missing ⚠️
packages/frontend/src/store.ts 0.00% 5 Missing ⚠️
packages/frontend/src/scripts/check-word-mute.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15195       +/-   ##
============================================
- Coverage    40.32%   20.00%   -20.32%     
============================================
  Files         1564      729      -835     
  Lines       198077   104086    -93991     
  Branches      3840     1199     -2641     
============================================
- Hits         79867    20827    -59040     
+ Misses      117607    82706    -34901     
+ Partials       603      553       -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tai-cha tai-cha marked this pull request as ready for review December 31, 2024 04:03
@tai-cha tai-cha changed the title ワードミュートで引っかかったワードを表示可能にする enhance(frontend): ワードミュートで引っかかったワードを表示可能にする Dec 31, 2024
@kakkokari-gtyih
Copy link
Contributor

たくさんのワードミュート条件に引っかかっている場合は「なにか言いました」の文字列が長くなりそう
いくつかだけ表示して残りは「~などについてなにか言いました」にするとか

@tai-cha
Copy link
Contributor Author

tai-cha commented Jan 10, 2025

たくさんのワードミュート条件に引っかかっている場合は「なにか言いました」の文字列が長くなりそう
いくつかだけ表示して残りは「~などについてなにか言いました」にするとか

一つだけでも引っかかっていればミュート条件としてひっかかっているので文言は変えずにとりあえず個数だけ制限します

@tai-cha tai-cha force-pushed the feat/wordmute-show branch from 1c17e16 to 764c6c3 Compare January 10, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Status: Approved
2 participants