Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(backend): チャートの処理を一つずつ行うことでDBの同時接続とタイムアウトを削減 #15239

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

What

書いてあるとおり

Why

All bulk chart operations are awaited instead of being mass-dispatched. This greatly reduces database load and resource contention, avoiding stalls, lags, and transaction errors while charts are ticked.

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jan 9, 2025
@kakkokari-gtyih kakkokari-gtyih changed the title enhance(backend): チャートの処理を一つずつ行うことでDBの同時接続とタイムアウトを削減するように enhance(backend): チャートの処理を一つずつ行うことでDBの同時接続とタイムアウトを削減 Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 3.12500% with 31 lines in your changes missing coverage. Please review.

Project coverage is 40.31%. Comparing base (13439e0) to head (0d801ef).

Files with missing lines Patch % Lines
...rc/queue/processors/CleanChartsProcessorService.ts 0.00% 12 Missing ⚠️
...src/queue/processors/TickChartsProcessorService.ts 0.00% 12 Missing ⚠️
...s/backend/src/core/chart/ChartManagementService.ts 20.00% 4 Missing ⚠️
...c/queue/processors/ResyncChartsProcessorService.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #15239   +/-   ##
========================================
  Coverage    40.31%   40.31%           
========================================
  Files         1564     1564           
  Lines       198083   198077    -6     
  Branches      3837     3839    +2     
========================================
  Hits         79863    79863           
- Misses      117617   117643   +26     
+ Partials       603      571   -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Jan 9, 2025

並列で処理可能なものを直列処理するのは自然ではないから、そうする理由を書いておいた方が良さそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

3 participants