Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(frontend): 削除して編集で引用ありを消せない #15249

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tai-cha
Copy link
Contributor

@tai-cha tai-cha commented Jan 10, 2025

What

削除して編集で引用を消すためにprops.renoteを直接利用せずいったん保管して消せるように

Why

Fix #14476
Close #15245

Additional info (optional)

変数名の命名が微妙な気がするのでいい代替があれば変えたい

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.87%. Comparing base (13439e0) to head (91f2634).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15249       +/-   ##
============================================
- Coverage    40.31%   19.87%   -20.44%     
============================================
  Files         1564      729      -835     
  Lines       198083   104055    -94028     
  Branches      3837     1200     -2637     
============================================
- Hits         79863    20686    -59177     
+ Misses      117617    82815    -34802     
+ Partials       603      554       -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

私が見た限り/試した限りでは良さそうです! ありがとうございます!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

「削除して編集」で引用として添付したノートを外せない
2 participants