refactor: WebhookDeliverJobDataのcontentフィールドの型を具体的に #15310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
SystemWebhookDeliverJobData
,UserWebhookDeliverJobData
の型を厳格にします。SystemWebhookDeliverJobData
T extends SystemWebhookEventType = SystemWebhookEventType
を追加します。type
フィールドの型をT
とします。content
フィールドの型をSystemWebhookPayload<T>
とします。UserWebhookDeliverJobData
T extends WebhookEventTypes = WebhookEventTypes
を追加します。type
フィールドの型をT
とします。content
フィールドの型をUserWebhookPayload<T>
とします。Why
ソースコードを読んでいると
content
にどんな値が入るかが分からなくて困った。Additional info (optional)
Checklist