fix(build): corepackのバグの回避

[kakkokari-gtyih]

What

Why

Fix #15386

Additional info (optional)

これでいけるかどうかは分からない

Checklist

• Read the contribution guide
• Test working in a local environment
• (If needed) Add story of storybook
• (If needed) Update CHANGELOG.md
• (If possible) Add tests

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.38%. Comparing base (9230ee5) to head (e61dd49).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #15387      +/-   ##
===========================================
+ Coverage    38.68%   40.38%   +1.69%     
===========================================
  Files         1603     1607       +4     
  Lines       204302   210127    +5825     
  Branches      4042     4084      +42     
===========================================
+ Hits         79040    84856    +5816     
- Misses      124622   124633      +11     
+ Partials       640      638       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

[anatawa12]

storybookはpull_request_targetなので小直してもエラーになりますので無視しましょう

[kakkokari-gtyih]

Test (federation) / Federation test が落ちてるのが謎

[anatawa12]

corepack enableを戻したいです

[Mar0xy]

corepack enable is obsolete here cause Install PNPM does the same thing (https://github.com/pnpm/action-setup) which is a few lines above. so either install pnpm step should be removed or corepack enable

[anatawa12]

we'ere currently generally using corepack so I prefer corepack enable and removing duplicate is out of scope of this PR.

[Mar0xy]

I think this should also be done in a seperate PR cause I noticed you tried to already make pnpm use the version specified in package.json with ed74f7b

but it never worked on some of the workflow files cause corepack enable later on overwrote it with the latest version upon running.

[anatawa12]

but it never worked on some of the workflow files cause corepack enable later on overwrote it with the latest version upon running.

corepack won't overwrite with latest version.

Corepack checks for latest version of package manager as a part of startup (of no latest version cache are not exists), to be used as default version when version is not specified.

Regardless which version is latest version recognized by corepack, corepack will use version defined in packageManager field.

[anatawa12]

federationテストはそっちでdockerの設定があるのでそれを治す必要がありそう。

misskey/packages/backend/test-federation/compose.tpl.yml

Lines 14 to 91 in a1be39d

	misskey:
	image: node:20
	env_file:
	- ./.config/docker.env
	environment:
	- NODE_ENV=production
	volumes:
	- type: bind
	source: ../../../built
	target: /misskey/built
	read_only: true
	- type: bind
	source: ../assets
	target: /misskey/packages/backend/assets
	read_only: true
	- type: bind
	source: ../built
	target: /misskey/packages/backend/built
	read_only: true
	- type: bind
	source: ../migration
	target: /misskey/packages/backend/migration
	read_only: true
	- type: bind
	source: ../ormconfig.js
	target: /misskey/packages/backend/ormconfig.js
	read_only: true
	- type: bind
	source: ../package.json
	target: /misskey/packages/backend/package.json
	read_only: true
	- type: bind
	source: ../../misskey-js/built
	target: /misskey/packages/misskey-js/built
	read_only: true
	- type: bind
	source: ../../misskey-js/package.json
	target: /misskey/packages/misskey-js/package.json
	read_only: true
	- type: bind
	source: ../../misskey-reversi/built
	target: /misskey/packages/misskey-reversi/built
	read_only: true
	- type: bind
	source: ../../misskey-reversi/package.json
	target: /misskey/packages/misskey-reversi/package.json
	read_only: true
	- type: bind
	source: ../../../healthcheck.sh
	target: /misskey/healthcheck.sh
	read_only: true
	- type: bind
	source: ../../../package.json
	target: /misskey/package.json
	read_only: true
	- type: bind
	source: ../../../pnpm-lock.yaml
	target: /misskey/pnpm-lock.yaml
	read_only: true
	- type: bind
	source: ../../../pnpm-workspace.yaml
	target: /misskey/pnpm-workspace.yaml
	read_only: true
	- type: bind
	source: ./certificates/rootCA.crt
	target: /usr/local/share/ca-certificates/rootCA.crt
	read_only: true
	working_dir: /misskey
	command: >
	bash -c "
	corepack enable && corepack prepare
	pnpm -F backend migrate
	pnpm -F backend start
	"
	healthcheck:
	test: bash /misskey/healthcheck.sh
	interval: 5s
	retries: 20

[anatawa12]

細かい話だけど pnpm のバージョンの強制自体はすでに行えてるので、 corepack のバグを回避する的な書き方のほうが正しいかもしれない。

[kakkokari-gtyih]

細かい話だけど pnpm のバージョンの強制自体はすでに行えてるので、 corepack のバグを回避する的な書き方のほうが正しいかもしれない。

(Off-topic) corepackが治ったらrevertする必要がある？それとも仕様的にそうだったけど今まで問題とならなかったということ？

[anatawa12]

revertする必要性はないかな。COREPACK_DEFAULT_TO_LATESTはpackageManagerがpackage.jsonに指定されている限りは(本来)関係ない環境変数なので。(corepackの内部実装の都合でバグのworkaroundにできてるけど別にそれが仕様とは言いづらいと思う)

更に細かい話だけど最新(というかpackageManagerで指定されているバージョンとは別のバージョン)がインストールされることはなくて、最新版がどのバージョンかだけをcorepackが取得してて、その途中に落ちるという問題なので、"インストールされるバージョンを固定する"も部分的に誤りかもしれない。

[mi-gh-maintainer]

Thank you 🙏