Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): use type-only imports in generated stories #15654

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

zyoshoka
Copy link
Contributor

What

verbatimModuleSyntax を有効化して以降 Storybook が動かなくなっているのを修正します。Story の生成ロジックを修正して型のみのインポートを行います。

Why

Follow-up to #15323

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Mar 12, 2025
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.29%. Comparing base (8508c4d) to head (23694a4).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15654       +/-   ##
============================================
- Coverage    41.84%   15.29%   -26.56%     
============================================
  Files         1626      788      -838     
  Lines       166236    72549    -93687     
  Branches      4124     1280     -2844     
============================================
- Hits         69568    11095    -58473     
+ Misses       96189    61028    -35161     
+ Partials       479      426       -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@syuilo syuilo merged commit aa1cc2f into misskey-dev:develop Mar 12, 2025
22 checks passed
@syuilo
Copy link
Member

syuilo commented Mar 12, 2025

🙏

@zyoshoka zyoshoka deleted the storybook-type-only-import branch March 12, 2025 09:12
DA-TENSHI pushed a commit to SHINANOSKEY-Projekt/SHINANOSKEY that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants