Enhance poll #4409
Merged
Enhance poll #4409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acid-chicken
added
🧩API
mei23
reviewed
Mar 4, 2019
There was a problem hiding this comment.
別件バグなんですが、以下の既存のバグにひかかっちゃうみたいです
note.to, note.cc が 非配列(string) や undefined だと落ちる
https://github.com/syuilo/misskey/blob/e947dbac70bfc87d04cbc65af50e88d4fb67d886/src/remote/activitypub/models/note.ts#L77-L78
note.attachment が 非配列(object) や undefined だと落ちる
https://github.com/syuilo/misskey/blob/e947dbac70bfc87d04cbc65af50e88d4fb67d886/src/remote/activitypub/models/note.ts#L98-L99
mei23
reviewed
Mar 4, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mei23
reviewed
Mar 4, 2019
mei23
reviewed
Mar 4, 2019
mei23
reviewed
Mar 4, 2019
* wip * 形式をMastodonと合わせた
mei23
reviewed
Mar 6, 2019
mei23
reviewed
Mar 6, 2019
|
もうやること全部やったかしら？ |
|
全体的にはこれで大丈夫そう |
|
なんかMastodonに投票出来なくてはまってるわ |
|
deliverあたりにlog出すように仕込んでおいた気がするので、 |
|
送ってるactorが違ってた |
mei23
approved these changes
Mar 6, 2019
|
お二方ありがとうございました & お疲れ様でした ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #3507
Resolves #4407
Resolves #4408
Related to #3940
Todo