AP audience (visibility) パースの修正 #5783
Merged
+124
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| visibleUsers = activityAudience.visibleUsers; | ||
| apMentions = activityAudience.mentionedUsers; | ||
| } else if (typeof value === 'string') { // 入力がstringならばresolverでGETが発生している | ||
| // こちらから匿名GET出来たものならばpublic |
There was a problem hiding this comment.
フォールバックとしては home がより妥当かなという気がしますが、どうでしょうか？
There was a problem hiding this comment.
公開範囲=未定義 ってことなのでなんともいえない
最初homeが無難かなとも思ったのですが
元々公開するための仕組みで公開範囲の概念がないのがデフォルトなのでpublicでいいかなと思いました。
あとhomeにすると、それを参照するRenote/Reply自体の公開範囲が常にhomeになっちゃいます。
Co-Authored-By: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
Co-Authored-By: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
syuilo
approved these changes
Jan 29, 2020
|
ありがとうございます 🙏 |
mei23
commented
May 2, 2024
| function isPublic(id: string) { | ||
| return [ | ||
| 'https://www.w3.org/ns/activitystreams#Public', | ||
| 'as#Public', |
There was a problem hiding this comment.
as:Publicの間違えだった #11347
mei23
commented
May 2, 2024
| return [ | ||
| 'https://www.w3.org/ns/activitystreams#Public', | ||
| 'as#Public', | ||
| 'Public', |
There was a problem hiding this comment.
元IssueにはPublicを認識させろとまでは言ってないし、
https://www.w3.org/TR/activitypub/#x5-6-public-addressing
いやそんなことなさそうだしうーん
being represented as simply Public or as:Public
Compactしてもas:Publicだし
Publicが来てもCanonize でエラーになるし
jsonld.ValidationError: Safe mode validation error.
{
"type": [
"JsonLdEvent"
],
"code": "relative object reference",
"level": "warning",
"message": "Relative object reference found.",
"details": {
"object": "Public"
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #4951
Resolve #5768
Resolve #5078
Resolve #5767
Activity の audience を見に行くように
匿名で取得できたのならば公開されているものに違いないとみなして public 扱いにするように。