カスタム絵文字をproxyに通すように #7526
Merged
カスタム絵文字をproxyに通すように #7526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
syuilo
reviewed
May 28, 2021
| @@ -59,9 +61,12 @@ export async function populateEmoji(emojiName: string, noteUserHost: string | nu | |||
|
|
|||
| if (emoji == null) return null; | |||
|
|
|||
| const isLocal = emojiName.endsWith('@.'); | |||
There was a problem hiding this comment.
ユーザー情報についてくる絵文字情報はローカルでも@.が付かないから判定条件変えないとダメだな
There was a problem hiding this comment.
nameの形式でも判定できないし(foo形式の文字列はローカルでもリモートでもありうる)、urlでも判定できない(外部のオブジェクトストレージとか使ってる可能性ある)
There was a problem hiding this comment.
まあ別にローカルなURLをさらにproxyに通しても問題は無いんだけど、無駄ではある
There was a problem hiding this comment.
すぐ上でDBクエリ用にhostをresolveしているので、普通にhostがnullかどうかで判定すればOK。
There was a problem hiding this comment.
ほんとだ
const isLocal = emoji.host == null;でいいかな
|
@rinsuki @mei23 @acid-chicken ↑良いアイデア募集中 |
|
|
|
あれ、その部分じゃない？ |
syuilo
added a commit
that referenced
this pull request
May 30, 2021
snk-lab
pushed a commit
to snk-lab/misskey-kusa-note
that referenced
this pull request
Sep 24, 2021
snk-lab
pushed a commit
to snk-lab/misskey-kusa-note
that referenced
this pull request
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #6451
試してないけどたぶん動く