enhance: アバターをサーバーで圧縮して取得する #8337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tamaina <tamaina@hotmail.co.jp>
クライアントサイド画像圧縮の準備
|
言うまでもなくp1.a9z.devで動作中 |
Johann150
reviewed
Feb 20, 2022
Comment on lines
-188
to
+195
| return `${config.url}/identicon/${user.id}`; | ||
| return this.getIdenticonUrl(user); | ||
| } | ||
| } | ||
|
|
||
| public getIdenticonUrl(user: User): string { | ||
| return `${config.url}/identicon/${user.id}`; | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't see why moving the same code into a separate function is necessary? Since its only one line, at most I think a comment would make sense here.
There was a problem hiding this comment.
Used at
| //#endregion | ||
|
|
||
| ctx.set('Content-Type', 'image/webp'); | ||
| ctx.set('Cache-Control', 'max-age=31536000, immutable'); |
There was a problem hiding this comment.
Since avatars can change multiple times in the span of a year I think this caching is a bit too agressive. I think something between a week and a month might make more sense? Or remove immutable because that is not the case.
There was a problem hiding this comment.
ここに至るまでに、クエリ文字列にurlを持たない場合はリダイレクトされるはずなのですが、どうでしょうか。
|
アバターって本来thumbnailが挿入されるべきなんだけど、p1.a9z.dev（TLに出現するのがほとんどリモートユーザー）でwebpublicばっかりになっているのは #7767 のバグのせいだということを理解した… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of #8319
#8216 のつづき
What
/avatar.webpにクエリ付きでアクセスすると、256x256にクロップ(cover)したアバターwebpを取得する or identiconへリダイレクト/avatarは削除Why
通信量削減