Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added apikey support, fixed rottentomato results, plus more #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added apikey support, fixed rottentomato results, plus more #30

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 31, 2017

has apikey support, all new results supported, rotten tomatoes fixed.

@noamokman
Copy link

@misterhat are you still maintaining this? looks like this module doesn't work anymore without the api key

@ghost
Copy link
Author

ghost commented Dec 26, 2017

@noamokman He stated in an issue post, that I had since deleted, that he has no plan on supporting this anymore, because of the mandatory api key. He had said he would transfer ownership to someone who wants to maintain it. I just did this PR so people looking for a fix can clone and use my repo for a working, updated copy.

@noamokman
Copy link

@notstevek got it.
Ended up using omdb-api-pt.
Works great.

@ghost
Copy link
Author

ghost commented Jan 19, 2018

@misterhat https://www.omdbapi.com/apikey.aspx free keys now. 1,000 daily limit

Copy link

@CodingButter CodingButter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants