Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split headers into key value at first colon #122

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

felixscherz
Copy link
Contributor

Hi, this is in regards to #121.
With this change, headers are split into key, value pairs at the first colon.

@gorillamoe gorillamoe self-assigned this Aug 12, 2024
@gorillamoe gorillamoe added the bug Something isn't working label Aug 12, 2024
@gorillamoe
Copy link
Member

What a great catch 😍 !!!

@gorillamoe gorillamoe merged commit c73fbf0 into mistweaverco:main Aug 12, 2024
@estacioneto
Copy link

estacioneto commented Nov 25, 2024

Hi,

First of all, nice catch indeed, @felixscherz!

kulala.inspect() still does not show the header so running kulala.run() from the computed buffer doesn't work. I'll investigate it to see if I can find where it's failing.

FYI @gorillamoe

Edit:

It happens because the parser removes the authorization header, so the inspect function does not get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants