Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): folds not working in lazy #279

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix(ui): folds not working in lazy #279

merged 1 commit into from
Oct 9, 2024

Conversation

gorillamoe
Copy link
Member

remove nofile, otherwise ts folds do not work in lazy.

remove nofile, otherwise ts folds do not work in lazy.
@gorillamoe gorillamoe added the bug Something isn't working label Oct 9, 2024
@gorillamoe gorillamoe self-assigned this Oct 9, 2024
@gorillamoe gorillamoe requested a review from Grueslayer as a code owner October 9, 2024 18:34
@gorillamoe
Copy link
Member Author

Should fix: #268

@gorillamoe gorillamoe merged commit a543d6e into main Oct 9, 2024
2 checks passed
@gorillamoe gorillamoe deleted the fix/folds-nofile branch October 9, 2024 18:36
@Grueslayer
Copy link
Contributor

That shouldn’t be the solution. We should talk with @folke about his reason to exclude this buftypes. I don’t use LazyVim but have some more plugins with scratch buffers using buftype nofile where treesitter runs fine and I see no reason to skip folding.

@gorillamoe
Copy link
Member Author

Yes, folding works for me too, I don't use Lazy either, so maybe folke can elaborate on why'd he chose to disable that on nofile 🤔

@rogeriofrsouza
Copy link

Can we solve it with a user configuration on setup?

Folke is on vacation till the end of the month 😞

@Grueslayer
Copy link
Contributor

@rogeriofrsouza you already confirmed that everything runs fine for you with this commit, didn’t you? So we can keep it as is (I haven’t tested for side effects). If Folke will change his repo we can do a revert (if @gorillamoe want to do it). So in the meantime everything should be good.

@gorillamoe
Copy link
Member Author

@rogeriofrsouza you already confirmed that everything runs fine for you with this commit, didn’t you? So we can keep it as is (I haven’t tested for side effects). If Folke will change his repo we can do a revert (if @gorillamoe want to do it). So in the meantime everything should be good.

Yes, I will revert this ofc, if behaviour in lazy changes.
Until then it should stay as is if nobody complains about side-effects. I haven't noticed side-effects for now, but let's see.

@rogeriofrsouza
Copy link

Yes @Grueslayer it is running fine. But I don't want to break someone else configuration out there...

@gorillamoe
Copy link
Member Author

Yes @Grueslayer it is running fine. But I don't want to break someone else configuration out there...

Don't worry, if it breaks stuff, we'll revert it and make it opt-in.

iamxiaojianzheng pushed a commit to iamxiaojianzheng/kulala.nvim that referenced this pull request Oct 24, 2024
remove nofile, otherwise ts folds do not work in lazy.
@Grueslayer
Copy link
Contributor

@gorillamoe It is fixed in LazyVim, may you revert this (and maybe #286, too)?

gorillamoe added a commit that referenced this pull request Nov 1, 2024
This reverts these quickfix commits:

#279
#286
gorillamoe added a commit that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants