Cmfd refactor to sync with ClosedMOC/3D-MOC #254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be accompanied by a PR to ClosedMOC/3D-MOC that syncs up the Cmfd, Vector, and Matrix classes and linalg functions as much as possible. Important changes in this PR include:
setValues(...)
andincrementValues(...)
added to Vector.cpp: This implements the Cmfd shared memory optimization that @jtramm started in PR Cmfd shared memory optimization #196.Lattice::getLatticeSurface(...)
reverted to general form: TheLattice::getLatticeSurface(...)
method made some assumptions on the numbering of the surfaces and edges that is not valid for 3D surfaces, so this method was reverted to the previous general form.splitCorners()
->splitEdgeCurrents()
: ThesplitCorners()
routine has been changed tosplitEdgeCurrents()
and the nomenclature for corners has been changed to edges to reflect the language commonly used elsewhere to describe a cube: