Add default platform for Docker builds #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses an issue seen with M-series Macs where Docker looks to pull images built for the linux/arm64/v8 platform instead of the linux/amd64 platform by default. Specifies platform: linux/amd64 in docker-compose files to fix this issue for Mac users. Minor note: also renames the image built / targeted by docker-compose-parsec-test.yml to opencbdc-tx-parsec instead of opencbdc-tx to match convention. Signed-off-by: Michael Maurer <maurer.mi@northeastern.edu>
|
Tested these changes on an M1 Mac and on my personal non-Mac system. Would be great to get approval from another M-series Mac user and a non-Mac user if possible. |
|
utACK. Specifies amd64 as the platform for all docker images so that the right image is grabbed by-default across any platform. Looks like we have a tACK from Hung Nguyen in the community. I don't have Apple Silicon to test on so I cannot give a tACK, but @maurermi if Hung's use serves as confirmation for you, I'm happy to approve and merge. |
|
@HalosGhost That sounds good to me! |
HalosGhost
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue seen with M-series Macs where Docker looks to pull images built for the linux/arm64/v8 platform instead of the linux/amd64 platform by default.
Specifies platform: linux/amd64 in docker-compose files to fix this issue for Mac users.
Minor additional change: also renames the image built / targeted by docker-compose-parsec-test.yml to opencbdc-tx-parsec instead of opencbdc-tx to match convention.